pvr.vuplus: webinterface cannot be reached since

DDuck007 · February 2, 2024 at 1:43 PM

Both builts are working - so it is 24504 I suppose …
The PR24504 enables a streambuffer and maybe the small xml-file containing information of the E2-Box is not returned correctly due to:

if (ShouldUseStreamBuffer(url))
{
m_pBuffer = std::make_unique<CFileStreamBuffer>(0);
m_pBuffer->Attach(m_pFile.get());
}

The function

bool CFile::ShouldUseStreamBuffer(const CURL& url) may return true due to:

if (URIUtils::IsNetworkFilesystem(url.Get()))
return true;

**heitbaum** · February 2, 2024 at 9:10 PM

This final build has only one revert

20240202210107-78a0ba1

0003-Revert-FileSystem-Refactored-and-improved-logic-to-u.patch

Can you please raise a Kodi issue - as there will need to be a fix in either the Kodi or the pvr.vuplus side.

DDuck007 · February 3, 2024 at 7:26 AM

This last build works as expected.

Issue raised: https://github.com/xbmc/xbmc/issues/24629

Hopefully it works - a bot said "ignored rules" ...

**mglae** · February 3, 2024 at 9:19 AM

As a guess the issue likely can be fixed by building Kodi with #22222

**heitbaum** · February 3, 2024 at 9:30 AM

I have compiled 20240203092151-78a0ba1 without the revert 24504 but with 22222 included.

DDuck007 · February 3, 2024 at 10:25 AM

It works !

Regarding patches I have a question: Creating a patch from PR is simple by just adding the .patch to the corresponding URL, but how to create the patch that reverts the PR?

**chewitt** · February 3, 2024 at 3:24 PM

Code

git revert <githash>
git format-patch HEAD~1

The first creates a new commit that reverts the githash for the problem commit. The second creates a patch file for the last commit, which you can then move to the relevant package/patches folder in the LE buildsystem.

DDuck007 · February 3, 2024 at 5:09 PM

Super - thank you very much!

phunkyfish · February 4, 2024 at 11:34 AM

A question. Does just reverting the offending commit fix this?

This feels like one of those rippling side effect issues that we don’t want to pull on coming into final beta.

**heitbaum** · February 4, 2024 at 12:42 PM

Quote from phunkyfish

A question. Does just reverting the offending commit fix this?
This feels like one of those rippling side effect issues that we don’t want to pull on coming into final beta.

DDuck007 confirmed testing with 20240202210107-78a0ba1 above. I can confirm it was a clean LE12:master build with only the one patch - 0003-Revert-FileSystem-Refactored-and-improved-logic-to-u.patch

phunkyfish · February 4, 2024 at 12:55 PM

Ok, thanks for confirming. It was hard to tell without access to the patch.

**heitbaum** · February 21, 2024 at 10:19 AM

PR raised in LE12 to include the now upstream fix - https://github.com/LibreELEC/LibreELEC.tv/pull/8645

**chewitt** · February 21, 2024 at 11:51 AM

Merged