TBS5580 support in LE10, LE11 and LE12 for RPi4

Forage · September 14, 2021 at 8:03 AM

Due to the absence of the CrazyCat drivers for DVB devices like TBS's in LE10 for the Rapsberry Pi 4 for the time being one needs to add them manually by compiling LE.

Here's a patch for the TBS5580 : linux-tbs5580.patch.txt. It's heavily inspired by the patch for the TBS5520SE by smp as both devices are almost identical.

Rename the file to remove the ".txt"
Place the file in one of the following folders, depending on you preference
- projects/RPi/devices/RPi4/patches/linux/
- packages/linux/patches/raspberrypi/
Add CONFIG_DVB_USB_TBS5580=m after CONFIG_DVB_USB_TECHNISAT_USB2=m to one of the following files, depending on the arch for which you are building
- projects/RPi/devices/RPi4/linux/linux.arm.conf
- projects/RPi/devices/RPi4/linux/linux.aarch64.conf
Build your LE image

Enjoy.

polo_joe · September 14, 2021 at 9:09 AM

Hi, could you please provide a test build, I have no build environment here.

**smp** · September 14, 2021 at 1:33 PM

I don't know if it works on 5580 but on 5520SE I enabled the green lock LED with this:

Diff

diff --git a/drivers/media/dvb-frontends/si2183.c b/drivers/media/dvb-frontends/si2183.c
index 4b5bc34..bbe3e96 100644
--- a/drivers/media/dvb-frontends/si2183.c
+++ b/drivers/media/dvb-frontends/si2183.c
@@ -1091,6 +1091,12 @@ static int si2183_init(struct dvb_frontend *fe)
       return ret;
    }
 
+    // set pins
+    memcpy(cmd.args, "\x12\x8\x0", 3);
+    cmd.wlen = 3;
+    cmd.rlen = 3;
+    si2183_cmd_execute(client, &cmd);
+
    dev->fw_loaded = true;
 warm:
    dev->active_fe |= (1 << fe->id);

Display More

Forage · September 14, 2021 at 5:41 PM

Quote from polo_joe

Hi, could you please provide a test build, I have no build environment here.

Here you can find the build I'm using myself:

LibreELEC-RPi4.arm-10.0-devel-20210913174257-beaa0c7.img

It's based on 10.0 stable.

Do note that it contains one more patch for libcec, to revert commit #ef8bc8e to fix issue #326.

Quote from smp

I don't know if it works on 5580 but on 5520SE I enabled the green lock LED with this:

Diff

diff --git a/drivers/media/dvb-frontends/si2183.c b/drivers/media/dvb-frontends/si2183.c
index 4b5bc34..bbe3e96 100644
--- a/drivers/media/dvb-frontends/si2183.c
+++ b/drivers/media/dvb-frontends/si2183.c
@@ -1091,6 +1091,12 @@ static int si2183_init(struct dvb_frontend *fe)
       return ret;
    }
 
+    // set pins
+    memcpy(cmd.args, "\x12\x8\x0", 3);
+    cmd.wlen = 3;
+    cmd.rlen = 3;
+    si2183_cmd_execute(client, &cmd);
+
    dev->fw_loaded = true;
 warm:
    dev->active_fe |= (1 << fe->id);

Display More

Cheers, will give that a try. I didn't even notice the additional led until now

Forage · September 14, 2021 at 6:19 PM

smp the patch works, thanks, I updated the patch in the initial post accordingly.

With the constant amount of light the green led is emitting I'm tempted to remove that bit again though

It only turns off very briefly when I stop watching a channel and than right back on again. Is this supposed to happen? The tuner is also constantly warm, or almost hot (as with LE 9), even when I'm not watching TV. Is this the case with your 5520SE as well?

**smp** · September 14, 2021 at 6:34 PM

Quote from Forage

It only turns off very briefly when I stop watching a channel and than right back on again

I use VDR/VNSI. It constantly scans transponders for EPG, so the LED is always on. It should turn off when there is no signal. Also, there is a short blink when switching from one frequency to another.

Does it turn off then there is no signal from antenna?

Quote from Forage

The tuner is also constantly warm

That's normal. Same with 5520SE.

polo_joe · September 14, 2021 at 7:26 PM

Quote from Forage

Here you can find the build I'm using myself

I realised I have tbs 5980, should this build work there too?

**smp** · September 14, 2021 at 7:29 PM

5980 is a completely different hardware and different drivers.

Forage · September 14, 2021 at 8:44 PM

Quote from smp

Does it turn off then there is no signal from antenna?

Yeah, right away when I disconnect the cable. So all good I suppose. Maybe I can dig up some Tvheadend setting that can put the device in some suspend state when I'm not watching anything.

**CvH** · September 15, 2021 at 11:17 AM Official Post

I guess upstreaming (to the linux kernel) this patch is likely not doable ?

Forage · September 15, 2021 at 11:31 AM

Quote from CvH

I guess upstreaming (to the linux kernel) this patch is likely not doable ?

Doable yes I suppose, but I don't think that's up to me.

Like smp I simply took the required sources from GitHub - tbsdtv/linux_media: TBS linux open source drivers. It should be TBS upstreaming their work in that repository to the kernel, but for some raison they don't.

**chewitt** · September 15, 2021 at 12:59 PM Official Post

Quote from Forage

It should be TBS upstreaming their work in that repository to the kernel, but for some raison they don't.

TBS has a love/hate relationship with upstreaming. All the people trying to use their devices and/or sustain support in distros are in favour of upstreaming and a couple of years ago they caved into the pressure and started releasing on GitHub which provided a consistent/common source for them. At the same time this has made it easier for cheap Chinese knock-offs of their boards to be produced so part of their team would like to revert to the less accessible "download tarballs via website" approach they had in the past. I'm not sure what the solution is, and it's a hard problem for a small manufacturer so I'm not sure they do either, so I wouldn't expect much change. Most of the drivers are rather messy anyway so the upstreaming process would need a ton of patience and persistence.

Forage · March 26, 2023 at 10:49 AM

Here are the updated kernel patches for LE11:

linux-01_tbs5580_dvb_support.patch.txt

linux-02_si2183_additions.patch.txt

The same changes, split into two separate patch files this time.

The first patch contains the original TBS Linux drivers. The second patch contains two changes on top of that to fix a compile issue and to add support for the green LED.

Compile steps are identical to those in the initial post, except for the removal of the "projects/RPi/devices/RPi4/linux/linux.arm.conf" file.

Here's a build based on LE11.0.1 for those who want to give it a try: https://drive.proton.me/urls/426XA2EBPW#P7SpOnFI6ihC

Do note that it contains the same additional patch as in my previously provided build in post 4.

Forage · December 29, 2023 at 10:39 AM

Here's an updated 11.0.4 RPi4 build, with a minor fix in one of the patches that was needed for the updated kernel.

linux-01_tbs5580_dvb_support.patch.txt

linux-02_si2183_additions.patch.txt

Proton Drive

Proton Drive allows you to securely store and share your sensitive documents and access them anywhere.

drive.proton.me

Forage · May 21, 2024 at 1:25 PM

Here's a 12.0.0 RPi4 build, with a minor fixes in one of the patches that were needed for the updated kernel.

linux-01_tbs5580_dvb_support.patch.txt

linux-02_si2183_additions.patch.txt

Proton Drive

Securely store, share, and access your important files and photos. Anytime, anywhere.

drive.proton.me

Forage · October 24, 2024 at 4:24 PM

Here's a 12.0.1 RPi4 build, with temporarily an additional patch to revert a change in the more recent kernel. This fixes an issue where the TBS device firmware wasn't loaded any more.

linux-01_tbs5580_dvb_support.patch.txt

linux-02_si2183_additions.patch.txt

linux-03_revert.patch.txt