Hello,
Is it possible to integrate Ampache addon in the LE repo?
GitHub - lusum/ampache-xbmc-plugin: KODI plugin for Ampache
I installed in the last estable LE but it fail to reproduce media, maybe it require some fixes for latest Kodi.
Regards.
Ampache addon
-
zorrua -
March 12, 2017 at 8:47 PM -
Thread is Unresolved
-
- Official Post
I wouldn't accept this as an addition to the LE add-on repo because there is no clear active/upstream maintainer (most of the forks are dead for years) and this is not an LE specific add-on, so it should be submitted (by the creator, or an active maintainer) to the Kodi repo not ours. NB: Some of the other GitHub forks have more recent commits than the one you found, which might solve your problem.
-
The plugin is in active development, and i'm the mantainer, if you need some information, you can mail me.
-
- Official Post
Our repo is intended for binary addons that are distro or hardware specific. I see no binary code in your add-on sources so unless there's some reason I'm not aware of the better place to submit it would be the Kodi addon repo where it can benefit all Kodi users vs. the smaller subset that run LibreELEC.
-
It is true, i have to change the addon to match the kodi addon coding style and add a logo, but i'm not a designer.
-
- Official Post
^ took me 5 mins to create from the logo image in GitHub, feel free to use it.
-
- Official Post
Please check with existing Kodi addons if the coding style is correct. The PRs I send you are only those things I saw at a first look.
If you PR your add-on to the Kodi repo and if something needs to be fixed, I'm sure the reviewers will tell you what you need to change.
-
- Official Post
To further DaVu point. Kodi reviewers do not expect anyone to submit something perfect first time. The review process is normal and submitting something "known bad" simply to get comprehensive feedback on the items that need fixing is perfectly okay (as long as that's clear up-front).