[service.libreelec.settings] Skinning

Hello,

This is not really a bug per se, but was unsure about the most appropriate place to post.

I am the current maintainer of the Unity skin for Kodi, and I'd like to make a request for the current XML files that are used for the service settings windows. Would you consider renaming the files to be more inline with the naming standard other Kodi scripts use and include the name of the service in the XML name?

Example:
service-LibreELEC-Settings-getPasskey.xml
service-LibreELEC-Settings-mainWindow.xml
service-LibreELEC-Settings-wizard.xml

This would greatly help in being able to skin the window correctly for libreelec vs openelec in skins other than confluence.

Thanks for your consideration,
Bumpaneer

Initial pull request submitted: Update Skin XML Files by bumpaneer · Pull Request #12 · LibreELEC/service.libreelec.settings · GitHub

Yes, the logos are hardcoded in mainWindow.xml (hence the need to start using a new xml name).

skin.unity/mainWindow.xml at Jarvis · bumpaneer/skin.unity · GitHub

Once LE builds start pulling in the updated service.libreelec.settings plugin (Merge pull request #12 from bumpaneer/master · LibreELEC/service.libreelec.settings@e93bf33 · GitHub) I can skin service-LibreELEC-Settings-mainWindow.xml appropriately.

The root of the problem is mainWindow.xml file name that both OE and LE currently reference. That is also the reason for all the missing labels in your screenshot, as the mainWindow.xml file in Unity is referencing a non-existent addon in an LE install.

skin.unity/mainWindow.xml at Jarvis · bumpaneer/skin.unity · GitHub

Any idea on a time-frame for when the updated service settings script will get pulled into LE builds?

I didn't want to overstep and bump the version of the addon (last bump: bump to v0.7.1 · LibreELEC/service.libreelec.settings@8183be9 · GitHub) and the corresponding package pull (last bump: settings: bump to v0.7.1 · LibreELEC/LibreELEC.tv@b3351e6 · GitHub). I figured I'd leave that up to a member of the team.

Edit: additionally it looks like there is a patch that may need to be adjust as well: LibreELEC.tv/LibreELEC-settings-0001-fix-for-kodi-17.patch at da0dfbac2ae226c65e51c909a8b661cd81fb984b · LibreELEC/LibreELEC.tv · GitHub

Quote from H0nch0

Bumpaneer does this skin have the same edits for live tv as Aeon nox does by Manic
that's been incorporated by bignoid or is it able to be implemented or something else of same sorts on your skin ?
i only ask as i am always on look out for skins that are compatible with DVB-* and had a look online at this looks good
for my usage would be Linux Ubuntu , windows,android, and wetek all of which has a dvb-* attached and i have found
that manics live tv mods have helped, so wonder if you have something similar or the same can be implemented ?

I'm not sure if this is what you are looking for, but Unity does support Live TV.

Unity

Just a single background right now, but it's on my list to add more customization options. The menus are all controlled by skinshortcuts, so you should be able to customize them however you want. Addons as sub-menu choices is definitely available.

Thanks chewitt.

The generic build on a chromebox. Thanks!