A question. Does just reverting the offending commit fix this?
This feels like one of those rippling side effect issues that we don’t want to pull on coming into final beta.
DDuck007 confirmed testing with 20240202210107-78a0ba1 above. I can confirm it was a clean LE12:master build with only the one patch - 0003-Revert-FileSystem-Refactored-and-improved-logic-to-u.patch
I have compiled 20240203092151-78a0ba1 without the revert 24504 but with 22222 included.
This final build has only one revert
20240202210107-78a0ba1
0003-Revert-FileSystem-Refactored-and-improved-logic-to-u.patch
Can you please raise a Kodi issue - as there will need to be a fix in either the Kodi or the pvr.vuplus side.
https://github.com/xbmc/xbmc/comp…523412baa548367
So it’s either https://github.com/xbmc/xbmc/pull/24509 or https://github.com/xbmc/xbmc/pull/24504
This is a build without 24504 - 78a2ef1
20240202123952-625e6d7
I have also built master with these 3 reverts corresponding to 24509*2, 24504*1 - this image should work if our analysis is right.
20240202124829-6a5c736
0001-Revert-video-Do-not-override-the-ListItem.Overlay-fo.patch
0002-Revert-guilib-refactor-file-item-SetOverlayImage.patch
0003-Revert-FileSystem-Refactored-and-improved-logic-to-u.patch
Next: What about Kodi 0974c687e415b2c7145e074ed523412baa548367
20240202095501-6a8d1b0
Ok - that was bad guessing on my part.
Let’s try with 20240202073527-8463e44 Kodi 6e2851d997860d7e5a57d912f32898ebe08f9680
Now we are down to
Are you using the Generic or Generic-legacy image? You need to use Generic-legacy.
2 builds to test.
20240201202442-d261730 Should work with Kodi 6e2a64f
20240201203400-cc05fdc Might not work with Kodi a018bcd
Thank you - just tested, it works
!
This narrows it down to Kodi between:
f3f1df1eab2a38b7039e57635a6597b37510481a and 06e228046c9f1316c7585bd61bfa1e28e22382da
git ls f3f1df1eab2a38b7039e57635a6597b37510481a...06e228046c9f1316c7585bd61bfa1e28e22382da
06e228046c Merge pull request #24524 from garbear/highlight-keyboards-mice [GitHub]
5fcbc4008b Merge pull request #24572 from joseluismarti/m_bWindowCreated [GitHub]
e9c645e66a Merge pull request #24567 from garbear/kill-dirmngr [GitHub]
a4b164c00c Merge pull request #24521 from jjd-uk/estuary_overlay_icons [GitHub]
a7020765b9 [Android][windowing] Initialize m_bWindowCreated [Jose Luis Marti]
950a17b7a0 [Agents] Add keyboard and mouse input [Garrett Brown]
09966e73a7 Merge pull request #24525 from garbear/optimize-keysym [GitHub]
6077686189 [video] Remove non-working context menu manage / info dialog buttons for versions (#24569) [GitHub]
b093e352db Merge pull request #24494 from fuzzard/cmake_android_versioning_removal [GitHub]
3fbd1d9150 Merge pull request #24523 from neo1973/fix_23867 [GitHub]
726479026b Merge pull request #24551 from fuzzard/depends_pycryptodome_fix [GitHub]
718643ba5e Add another msys2 binary to fix game add-on build failures [Garrett Brown]
ada31755f5 [Keyboard] Optimize keyboard symbol translation [Garrett Brown]
724091127f Merge pull request #24518 from garbear/game-api-keyboard-mouse [GitHub]
acb1cc01cd Merge pull request #24513 from garbear/fix-port-focus [GitHub]
811c25b3cc Merge pull request #24563 from enen92/dup_context [GitHub]
6fde92b3d3 Revert "[guilib][utils] Set IsPlayable false on add items" [enen92]
ce1d70b155 Merge pull request #24531 from garbear/kill-gpg-agent [GitHub]
b757f12254 Game API v3.0.2: Add /keyboard and /mouse addresses [Garrett Brown]
c5d225c539 Game API v3.0.1: Begin port address with a / [Garrett Brown]
0d57b14231 Game API: Improve documentation [Garrett Brown]
28aaccfa53 Merge pull request #24512 from garbear/default-maps [GitHub]
39fd9874cc Merge pull request #24538 from CrystalP/versions-art-v3 [GitHub]
8dfa028c18 [videodb] optimize and make GetArtForAsset() more readable [CrystalP]
3dff5d0227 [videodb] Move default version filter into GetFilter() [CrystalP]
62071d4cba [videodb] Simplify GetArtForAsset() [CrystalP]
b79c9c80de [video] Show version art with fallback to movie art, except when choosing version art [CrystalP]
ac5a221177 [videodb] Ignore empty art [CrystalP]
95055e41ab [video] use version specific art only when navigating individual versions. Movie art otherwise. [CrystalP]
677676ef27 Merge pull request #24556 from enen92/keys_macos [GitHub]
b7903822a2 MacOS: add missing key mappings [Miguel Borges de Freitas]
630a222bff Merge pull request #24554 from fritsch/channels [GitHub]
d8d33e9d1e Merge pull request #24553 from fritsch/floatmultiagain [GitHub]
863dc82936 AESinkAudioTrack: Allow multi-channel float by advanced setting [fritsch]
7babe2093f AESinkAUDIOTRACK: Remove for now unneded AEChannelToAUDIOTRACKChannel method [fritsch]
ff370e5811 AudioTrack: Simplify Channel selection [fritsch]
e05cf962b1 Merge pull request #24505 from andred/master [GitHub]
be239ea149 [android] remove pre-emptive change for PIL lib copying [fuzzard]
719fb584ca [tools/depends][native] Rustup 1.75.0 [fuzzard]
a53b8a27c6 [android] Fix stripping ".abi3." from pycryptodome lib names [fuzzard]
986851789a Merge pull request #24527 from DaVukovic/streamdetails [GitHub]
734d9422c1 [Estuary] Refactor of poster/widget overlay icons [jjd-uk]
e007eb08b5 Merge pull request #24541 from kambala-decapitator/tvos-framework-gen [GitHub]
835caf68d2 Merge pull request #24363 from fritsch/pwsample [GitHub]
d2df90d5ee Merge pull request #24543 from enen92/python_context [GitHub]
a018bcd991 Merge pull request #24528 from ksooo/pvr-epg-tag-playlist [GitHub]
5d5a1041b3 [ContextMenus] Don't populate python context items if browsing sub-menus [enen92]
73ea9a6d34 [video] rework dimensions [David Vukovic]
14615970b6 log script commands [Andrey Filipenkov]
c87c89e383 use only PlistBuddy to read bundle ID [Andrey Filipenkov]
2c4f881408 Speed up game-addon build time [Garrett Brown]
656307146a Merge pull request #24534 from thexai/wasapi-fallback [GitHub]
4f25caeefd AESinkWASAPI: adjust log messages for fallback code path [thexai]
76e5236751 AESinkWASAPI: improve fallback when is not supported exact output channel layout [thexai]
7b71cff7bf Fix the scourge of game add-on failures [Garrett Brown]
67d10230fa [Peripherals] Add default buttonmaps for keyboard/mouse [Garrett Brown]
bb1a8618d3 Merge pull request #24501 from garbear/refactor-input [GitHub]
360c463b5e [pvr] Add context menu item 'play programme from here'/'play only this programme'. [ksooo]
01c20ca87a [pvr] Introduce setting to toggle 'auto play next programme'. [ksooo]
92e11a412f [pvr] Prevent to close the player while we are playing the 'epg playlist'. [ksooo]
94d0c3739a [pvr] Implement automatic playback of next epg tag in timeline. [ksooo]
a9acef0aa6 [pvr] Refactor: Move CPVRGUIActionsPlayback::StartPlayback to class CPVRPlaybackState. [ksooo]
697db1bed6 [pvr] CPVRManager::OnPlaybackEnded: Propagate the correct state to the playback state instance. [ksooo]
6e2a64f3fb Merge pull request #24522 from enen92/sane_datacachecore [GitHub]
a01c2d480d Merge pull request #24519 from joseluismarti/xbmc.properties [GitHub]
653855b99b [Games] Rename game input functions for code clarity [Garrett Brown]
e4a6e16339 [Peripherals] Add missing \ingroup tags [Garrett Brown]
56f5be3e29 [Peripherals] Move events to subfolder [Garrett Brown]
57e6dc9fc1 [Peripherals] Update copyright year to 2024 [Garrett Brown]
c01bb1653a [Peripherals] Factor add-on lookup out of buttonmap [Garrett Brown]
050c013eb8 [Peripherals] Rename member variables for code clarity [Garrett Brown]
e4fbdd9e41 [Input] Update copyright year to 2024 [Garrett Brown]
7fef0f51a4 [Keyboard] Rename KeySymbol to XBMCKey for code clarity [Garrett Brown]
371ef7cab7 [Keyboard] Refactor keyboard files into input/keyboard/ folder [Garrett Brown]
aa24e0282d [Keymaps] Refactor keymap code to new folder [Garrett Brown]
8dcf9b7859 [Mouse] Refactor CMouseEvent into input/mouse/ folder [Garrett Brown]
14375a75b5 [Mouse] Move interfaces to new CMakeLists.txt [Garrett Brown]
0be21939fb [Joysticks] Move interfaces to new CMakeLists.txt [Garrett Brown]
2f203f9386 [Joysticks] Add missing \ingroup tags [Garrett Brown]
2bf543b53c [Remote] Remove unused struct [Garrett Brown]
ad1423271d [Remote] Move interface to new CMakeLists.txt [Garrett Brown]
c5130dfe7c [Hardware] Move interface to new CMakeLists.txt [Garrett Brown]
e524b7d065 [Actions] Move CActionTranslator to KODI::ACTION namespace [Garrett Brown]
59de376c89 [Actions] Move IActionListener into actions folder [Garrett Brown]
3243b02c75 [CMake] Move input subdirectories to new treedata file [Garrett Brown]
b22539947c Merge pull request #24406 from garbear/better-player-viewer [GitHub]
1ee88ab8e4 EGLUtils: Fix nullptr usage in EglErrorCallback [Markus Härer]
1b1ed308f8 Merge pull request #24516 from dbarkar/fix-vc1 [GitHub]
ccc18e9258 Merge pull request #24520 from notspiff/add_avif_support [GitHub]
a2fcf38c86 [Datacachecore] Initiallize SStateInfo with sane values [enen92]
71864d6030 added: enable .avif image support in ffmpeg image [Arne Morten Kvarving]
ac7616dba1 AndroidMediaCodec: Retry VC1 fix [Denis Barkar]
cb50dfa1df [Android] file xbmc.properties is no longer needed [Jose Luis Marti]
0974c687e4 Merge pull request #24504 from thexai/stream-buffer [GitHub]
78a2ef1ef0 Merge pull request #24509 from CrystalP/fix-watched-versionsfolder [GitHub]
ee80a0cc22 AESinkPipewire: Set Samplerate for the node [fritsch]
6e2851d997 Merge pull request #24515 from joseluismarti/abi-check-removal [GitHub]
b7c903fbae [Android] ABI check removal [Jose Luis Marti]
3163a6cb45 [Joysticks] Fix broken focus on emulated analog stick [Garrett Brown]
1bf1c3611f [guilib] refactor file item SetOverlayImage [CrystalP]
13c967dec6 [video] Do not override the ListItem.Overlay for the navigation parent of versions [CrystalP]
378205d16f [VideoDB] restore compatibility with MariaDB < 10.5.2 [André Draszik]
8a9b0fd9c5 [FileSystem] Refactored and improved logic to use CFileStreamBuffer [thexai]
fdef39a321 [Android] Remove special versioning for Android arch types [fuzzard]
a5661a6e1d Player Viewer: Add keyboard and mouse controllers and improve sorting [Garrett Brown]
aaf2d6b3b1 Player Viewer: Refactor agent input for code clarity [Garrett Brown]
dc76e685df Player Viewer: Fix jumping past first controller when window is re-opened [Garrett Brown]docker@06docker@0696b409c02b:/var/media/DATA/home-rudi/xbmc$ I have built an image using LE12:master - but rolling back kodi to the "suspected known good"
this is the tree that I have built from
The img and the addon zip file are located:
just checked - unfortunately same error …
Just confirming - this is using both the LE12 nightly 20240130-af98f8f with the custom compiled pvr.vuplus-21.1.1.2.zip ?
I’m building a zip of pvr.vuplus against Kodi cabba8d. Which is in https://test.libreelec.tv/12.0/RPi/RPi5/…-af98f8f.img.gz for you to test. I don’t see anything specific either, but there has been some internal Kodi dependancy change in cabba8d.
I believe I can see that tethered mode is set on your Librelec. Can you please check and disable.
It’s kicked off daily at 14:15 UTC.
Build for LE12 (18 images) takes roughly 18 hours.
Just checked 5 image builds left to go.
For LE12. We initially were continuing to run arm32 on the 64bit devices. All 64bit devices are now running aarch64 (Rockchip was one of the last to be changed over.)
When changing over from arm to aarch64 you will need to update the binary addons.
I’m not sure on the LE check itself - by Manual intervention using the .update folder is the way forward.
** In LE12 there are no more arm builds for the 64bit systems, only aarch64.
They are there it’s just the sort that is wrong. And arm versus aarch64.
Search for:
LibreELEC-RK3328.aarch64-12.0-nightly-20240116-b7b2da0-rock64.img.gz (sha256)
Thanks for the info. I am glad to hear that Nucs are still extensively used for testing. I am however sorry to learn, that especially the 11gen have issues. The reason I got myself a nuc11 after years of happy using a nuc5 was that the nuc11 are the last ones with CIR. Also the nuc12 seemed even more overkill. I guess I'll now have to wait for the ASUS p42 with a n100 to start working, although I'd rather prefer my Nuc11. It's the smallest i3 (the pentiums don't have CIR). Any chance the nuc11 issues (what are they one you know about?) get resolved. I have issues with Audio coming and going and passthrouh not working as mentioned above near the starting posts of this thread.
The other issue has to do with the tv.hts client not playing uhd streams with VAAPI, which, I guess, is not really related to the chip.
I haven’t tested nuc11 for ages but the pass through “issue” I was able to reproduce on the NUC11PAHi7 regularly. The coming and going audio I have not experienced. The issue I experienced was “audio goes” and a reboot was required.
