Samba package build

I noticed that the samba package is not built unless KODI_SAMBA_SUPPORT is set to yes.
SAMBA_SUPPORT="yes" and SAMBA_SERVER="yes" have no effect if KODI_SAMBA_SUPPORT="no"

My workaround is to add

if [ "$SAMBA_SERVER" = "yes" ] || [ "$SAMBA_SUPPORT" = "yes" ]; then
  PKG_DEPENDS_TARGET="$PKG_DEPENDS_TARGET samba"
fi

at the end of packages/virtual/network/package.mk

If this is the right way to do and that was forgotten then can it be added please ?

No, but I'm building Kodi without built-in samba client and this prevents building OS samba client/server :

olivier@backup:~$ fgrep -r samba LibreELEC.tv/packages/ | grep DEPENDS
LibreELEC.tv/packages/mediacenter/kodi/package.mk:  PKG_DEPENDS_TARGET="$PKG_DEPENDS_TARGET samba"

and

if [ "$KODI_SAMBA_SUPPORT" = yes ]; then
  PKG_DEPENDS_TARGET="$PKG_DEPENDS_TARGET samba"
  KODI_SAMBA="-DENABLE_SMBCLIENT=ON"
else
  KODI_SAMBA="-DENABLE_SMBCLIENT=OFF"
fi

So this is the only way to build the samba package.

Quote from lrusak

If it makes sense then you can make a PR to our repo

Sorry but each time I try to do something with github it never work and I mess everything and annoy everyone.

Edit: I will try nonetheless

Edit2: Done, the right way I hope !