[RK3588S] LE for Radxa Rock 5C

gnarlsnishi I can see the device-tree for Rock 5A/5C is missing the &hdmi0_sound node so I think you will only see the Analogue audio output on the board? - If yes, the images in my test share have been updated to add that and HDMI audio should be visible. If you can test and confirm HDMI audio is now working (for PCM output) I'll send the patch/change upstream to the kernel.

gnarlsnishi The only other difference I can see in hdmi0 nodes between Rock 5b (3588) and 5c (3588s) is something related to FRL support which is not (or should not be) linked to HDMI audio support. I've updated the rock5c image in my testing share so device-tree has the extra line though, but I can't see it changing anything. So:

a) Put Kodi in debug mode, update to the latest 5c image in my test-share, reboot, then run "pastekodi" and share the URL so I can see some other things in the system log.

b) If that didn't magically change something, edit extlinux.conf in the boot partition of the SD card and experiment with some other rk3588s board device-tree files (all are in the 'rockchip' folder on the SD card) and see what happens. Some might not boot. Some might not show HDMI either. If one does show HDMI audio .. let me know which one.

EDIT: Wait 30 mins until I rebuilt and sync'ed new files!

EDIT: Files are now posted..

Oct 13 15:01:55.422594 LibreELEC kernel: dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
Oct 13 15:01:55.422709 LibreELEC kernel: rockchip-drm display-subsystem: [drm] HDMI Sink doesn't support RGB, something's wrong.

^ No idea what this means, but I have a hunch this is likely to be responsible.

chewitt
I tested your 20251107 image on my rock5a.
HDMI audio device was not shown.
Log hrer: https://paste.libreelec.tv/advanced-snake.log

BTW, I got HDMI audio device on my rock5a with attached DT patch.
rockchip-9999-add_enable_rock5a_hdmiaudio.patch.txt please remove ".txt" from file name
But this patch has a problem that lost rk3588-es8316 device \when patch is enabled.

And I couldn't confirm it on my rock 5c because my rock 5c has same problem with gnarlsnishi

chewitt Where can I see/try your patch/image? The following patch needs to be applied for HDMI sound on ROCK 5C.

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index dd7317bab6135..1cd92a18f916d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -278,6 +278,10 @@ hdmi0_out_con: endpoint {
        };
 };
 
+&hdmi0_sound {
+       status = "okay";
+};
+
 &hdptxphy0 {
        status = "okay";
 };
@@ -405,6 +409,10 @@ i2s0_8ch_p0_0: endpoint {
        };
 };
 
+&i2s5_8ch {
+       status = "okay";
+};
+
 &mdio1 {
        rgmii_phy1: ethernet-phy@1 {
                compatible = "ethernet-phy-id001c.c916";

I have several patches for the ROCK 5C. I plan to update and post them. They will include support for new features, such as HDMI sound.

chewitt  RadxaNaoki
I was able to get HDMI audio on my rock5c with above RadxaNaoki's patch.
Many thanks!

But still logged "fde80000.hdmi: i2c read timed out" in journalctl log.
> LibreELEC kernel: dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out

rock5c's kodi also doesn't show rk3588-es8316 audio device after apply patch.
but "aplay -L" shows "rk3588es8316".
> LibreELEC:~ # aplay -L
> null
> Discard all samples (playback) or generate zero samples (capture)
> default:CARD=hdmi0
> hdmi0, fddf0000.i2s-i2s-hifi i2s-hifi-0
> Default Audio Device
> sysdefault:CARD=hdmi0
> hdmi0, fddf0000.i2s-i2s-hifi i2s-hifi-0
> Default Audio Device
> default:CARD=rk3588es8316
> rk3588-es8316, fe470000.i2s-ES8316 HiFi ES8316 HiFi-0
> Default Audio Device
> sysdefault:CARD=rk3588es8316
> rk3588-es8316, fe470000.i2s-ES8316 HiFi ES8316 HiFi-0
> Default Audio Device
> LibreELEC:~ #

Please let me know if "pastekodi" is needed.

@chewitt

I just try to build Rockchip khadas-edge2 from this github - https://github.com/chewitt/LibreELEC.tv/tree/rockchip

And I got this error:

FAILED: [code=1] build/cores/VideoPlayer/codecs/video/CMakeFiles/dvdvideocodecs.dir/DVDVideoCodecDRMPRIME.cpp.o

Link for the log file:

Can you help to resolve this issue?