Problem building package on LibreELEC 10

nuive · November 5, 2022 at 6:37 PM

Hi,

I'm having a problem building a package on LibreELEC 10.0.

The package in question is the Speech Dispatcher service. Many months ago I asked on this forum about integrating that package into LibreELEC 9.2, and I could add it without any problem after some modifications.

But now, trying to add this same package to LE10 I get the following error when building it:

Code

CCLD     speech-dispatcher
../../src/common/.libs/libcommon.a(libcommon_la-speak_queue.o):speak_queue.c:function module_speak_queue_add_audio: error: undefined reference to 'g_memdup2'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:558: speech-dispatcher] Error 1

Looking on Google I found something about the system not being fully updated or something like that, but I don't understand what is the problem here, in LibreELEC 9 this builds without any problem.

Here is the package.mk:

Code

PKG_NAME="speech-dispatcher"
PKG_VERSION="0.11.0"
PKG_SHA256="254c4279c7637ee815c9daee99597d208681f811af5188051f0c2e11f2ec77c7"
PKG_LICENSE="LGPL"
PKG_SITE="https://freebsoft.org/speechd"
PKG_URL="https://github.com/brailcom/speechd/releases/download/$PKG_VERSION/$PKG_NAME-$PKG_VERSION.tar.gz"
PKG_DEPENDS_TARGET="toolchain glib dotconf libsndfile libpthread-stubs alsa-lib pulseaudio"
PKG_LONGDESC="Common high-level interface to SS"
PKG_TOOLCHAIN="autotools"


PKG_CONFIGURE_OPTS_TARGET="ac_cv_func_realloc_0_nonnull=yes \
ac_cv_func_malloc_0_nonnull=yes"


post_unpack() {
find "${PKG_BUILD}" -name "*" -type f -exec sed -i 's:g_strdup_printf("%s/../libexec/speech-dispatcher-modules", user_data_dir);:g_strdup_printf("%s/modules", SpeechdOptions.runtime_speechd_dir);:g' {} \;
}


post_makeinstall_target() {
cp -a $PKG_DIR/locale $INSTALL/usr/lib/
}

Display More

Thanks for any help.

Edit: I have more information.

The problem seems to be related to this fragment of code:

Code

#if GLIB_VERSION_CUR_STABLE >= G_ENCODE_VERSION(2, 68)
playback_queue_entry->data.audio.track.samples = g_memdup2(track->samples, nbytes);
#else
playback_queue_entry->data.audio.track.samples = g_memdup(track->samples, nbytes);
#endif

For some reason, it detects that GLib version is greater than 2.68, even if Glib's included with LibreELEC 10 is 2.67.2.

**chewitt** · November 6, 2022 at 4:26 AM

Patch the code so that both calls use g_memdup ?

**heitbaum** · November 6, 2022 at 6:47 AM Best Answer

nuive - issue is the way stable an unstable are handled in glib. Here is the fix - you are welcome to upstream it.

Diff

Author: Rudi Heitbaum <[email protected]>
Date:   Sun Nov 6 06:41:10 2022 +0000

    Fix G_ENCODE_VERSION for unstable 2.67 versions
    
    Signed-off-by: Rudi Heitbaum <[email protected]>

diff --git a/src/common/speak_queue.c b/src/common/speak_queue.c
index 1b40de78..7f383b2d 100644
--- a/src/common/speak_queue.c
+++ b/src/common/speak_queue.c
@@ -239,7 +239,7 @@ module_speak_queue_add_audio(const AudioTrack *track, AudioFormat format)
        playback_queue_entry->type = SPEAK_QUEUE_QET_AUDIO;
        playback_queue_entry->data.audio.track = *track;
        gint nbytes = track->bits / 8 * track->num_samples;
-#if GLIB_VERSION_CUR_STABLE >= G_ENCODE_VERSION(2, 68)
+#if G_ENCODE_VERSION(GLIB_MAJOR_VERSION, GLIB_MINOR_VERSION) >= G_ENCODE_VERSION(2, 68)
        playback_queue_entry->data.audio.track.samples = g_memdup2(track->samples, nbytes);
 #else
        playback_queue_entry->data.audio.track.samples = g_memdup(track->samples, nbytes);

Display More

nuive · November 6, 2022 at 4:40 PM

Yes, it solved the problem.

Thank you very much.

Problem building package on LibreELEC 10

Similar Threads

LibreELEC (Matrix) 10.0.3

Package dependency not building

LE 10.0.2 GUI animation stutter/ugly/slow on 1080p