Need some help submitting a patch/PR

  • See also: RE: Asus PN50 challenge

    There was an issue with the IR module not working on the ASUS PN50. A kernel patch was developed and in newer kernel versions (i.e. LE 11 nightlies) it now works.

    Patchwork link: https://patchwork.kernel.org/project/linux-…[email protected]/


    I need a bit of help doing a PR on the 10.0 branch to backport this (I have already tested it).

    1. Should there be a relevant issue opened before the PR ?
    2. How are patch files in "packages/linux/patches/default" named? How should my patch file be named?

  • Hi beredim - looks like it was added in 5.13-rc1 - https://lkml.org/lkml/2021/4/27/526

    Any reason why you would want to run the PN50 with LE10 versus the nightlies? I know I had to run 5.12+ to get a good experience with the Intel TGL. Naming patch files is done via git-format-patch. And the numbering is not really formalised in the Linux patches - whilst the Kodi patches are “999.* - patches backported from upstream”? I’m probably not in favour of backporting that patch into the libreelec-10.0 branch as a patch. Was the patch backported in into the 5.10.x series? (Could be an option to bump the kernel to 5.10.x) From a testing perspective - any patch in default should,be tested against all of the other architectures.)

    An alternative option for you could be to backport the couple of 5.15 commits from HEAD into your development branch and run with your community image. The planned release schedule of 10.0.x is definitely not fast and furious :)

    At some stage there will be a kernel bump for Generic (but probably not till 10.2 and would probably be a backport of something from nightlies). But none planned for 10.0.x at this time.