Docker addon server incorrectly versioned

watsonbox · June 9, 2024 at 9:58 AM New

Hello,

I've run into an issue setting up cadvisor on LibreELEC (in docker).

It checks the docker engine version when loading some of its monitoring stack and fails:

factory.go:219] Registration of the docker container factory failed: failed to validate Docker info: version string "library-import" doesn't match expected regular expression: "(\d+)\.(\d+)\.(\d+)"

Sure enough docker version reports:

Server:
Engine:
Version: library-import

I checked another system and the engine version is reported fine.

Can this be resolved, presumably in the addon build workflow somewhere?

Kind Regards.

**chewitt** · June 9, 2024 at 12:14 PM New

Code

LEIoT:~ # docker version
Client:
 Version:           26.1.3
 API version:       1.45
 Go version:        go1.22.3
 Git commit:        b72abbb6f0351eb22e5c7bdbba9112fef6b41429
 Built:             Fri Jun  7 14:43:10 UTC 2024
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          library-import
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.22.3
  Git commit:       library-import
  Built:            library-import
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.17
  GitCommit:        3a4de459a68952ffb703bbe7f2290861a75b6b67
 runc:
  Version:          1.1.12
  GitCommit:        51d5e94601ceffbbd85688df1c928ecccbfa4685
 docker-init:
  Version:          0.19.0
  GitCommit:

Display More

Odd .. this is what I see ^ albeit this is with a custom image where Docker is embedded (not installed as an add-on as there's no Kodi in the image) but I'd expect the results to be the same (as same build system).

**heitbaum** · June 9, 2024 at 1:45 PM New

Looks ok here

Code

nuc12:~ # docker version
Client:
 Version:           26.1.4
 API version:       1.45
 Go version:        go1.22.4
 Git commit:        5650f9b10226d75e8e9a490a31cc3e5b846e0034
 Built:             Thu Jun  6 20:30:59 UTC 2024
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          library-import
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.22.4
  Git commit:       library-import
  Built:            library-import
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          1.7.18
  GitCommit:        ae71819c4f5e67bb4d5ae76a6b735f29cc25774e
 runc:
  Version:          1.1.12
  GitCommit:        51d5e94601ceffbbd85688df1c928ecccbfa4685
 docker-init:
  Version:          0.19.0
  GitCommit:

Display More

**heitbaum** · June 9, 2024 at 2:13 PM New

Fixed https://github.com/LibreELEC/LibreELEC.tv/pull/8971

watsonbox · June 9, 2024 at 5:13 PM New

Yes you guys do both appear to have the same issue as I do: it's line 13 not 3 that causes the problem.

Though I don't understand _why_, I understand from the PR that it's now fixed in the source.

Thanks for such an incredibly fast turnaround 🙏.