TV adapter drivers missing from 11.0.4?

Rataplan626 · February 19, 2024 at 10:29 PM

I got it to build. I'll try to find the breaking commit and report.

Rataplan626 · February 20, 2024 at 12:46 PM

This is what came out:

Code

5d0fe30be4e28abe373bf951416f29afb0651e01 is the first bad commit
commit 5d0fe30be4e28abe373bf951416f29afb0651e01
Author: Christoph Hellwig <[email protected]>
Date:   Tue Aug 1 19:35:44 2023 +0200
   modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules
   
   commit 9011e49d54dcc7653ebb8a1e05b5badb5ecfa9f9 upstream.
   
   It has recently come to my attention that nvidia is circumventing the
   protection added in 262e6ae7081d ("modules: inherit
   TAINT_PROPRIETARY_MODULE") by importing exports from their proprietary
   modules into an allegedly GPL licensed module and then rexporting them.
   
   Given that symbol_get was only ever intended for tightly cooperating
   modules using very internal symbols it is logical to restrict it to
   being used on EXPORT_SYMBOL_GPL and prevent nvidia from costly DMCA
   Circumvention of Access Controls law suites.
   
   All symbols except for four used through symbol_get were already exported
   as EXPORT_SYMBOL_GPL, and the remaining four ones were switched over in
   the preparation patches.
   
   Fixes: 262e6ae7081d ("modules: inherit TAINT_PROPRIETARY_MODULE")
   Signed-off-by: Christoph Hellwig <[email protected]>
   Reviewed-by: Greg Kroah-Hartman <[email protected]>
   Signed-off-by: Luis Chamberlain <[email protected]>
   Signed-off-by: Greg Kroah-Hartman <[email protected]>
kernel/module/main.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)

Display More

It talks about NVidia, which doesn't have much to do with this I suppose, but it seemingly affects these TV tuners in TVHeadend.

So... now what

**chewitt** · February 20, 2024 at 5:46 PM

Is this patch in the kernel source? https://patchwork.kernel.org/project/linux-…foundation.org/

Rataplan626 · February 20, 2024 at 5:56 PM

I'm really sorry for my compile noobness, but how do I check?

**smp** · February 20, 2024 at 6:11 PM

Quote from Rataplan626

but it seemingly affects these TV tuners in TVHeadend

This was fixed by https://github.com/torvalds/linux…4c05c89f46e41d1

Rataplan626 · February 20, 2024 at 6:21 PM

Sounds good. So when Raspbian incorporates that into their builds, it will one day 'automatically' end up in LE? Is that how things work? Now I have this build system up and running, can I build an 11.0.6 with this patch incorporated?

**smp** · February 20, 2024 at 6:32 PM

DVB was broken in 6.1.52 and fixed in 6.1.53. LE 11.0.4 use kernel 6.1.68. So this must be something else.

**chewitt** · February 21, 2024 at 1:50 AM

Quote from Rataplan626

I'm really sorry for my compile noobness, but how do I check?

"git show <hash>" should output the patch content if the upstream kernel hashes have been merged correctly into the downstream Raspberry Pi kernel source that we use with RPi images. If they haven't, that will error and you'll have to search (grep) the commit log to find the commit message and confirm the patch is present.

Rataplan626 · May 7, 2024 at 1:47 PM New

Sorry for the late reply, life hit me hard the last couple of weeks. Getting everything back on track now. This weekend I updated to LE12 on a test SD-card, and it still doesn't work. My build-vm is still on 11 though.

git seems to report that patch is present:

Code

git show 5d0fe30be4e28abe373bf951416f29afb0651e01
commit 5d0fe30be4e28abe373bf951416f29afb0651e01 (refs/bisect/bad)
Author: Christoph Hellwig <[email protected]>
Date:   Tue Aug 1 19:35:44 2023 +0200

    modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules
    
    commit 9011e49d54dcc7653ebb8a1e05b5badb5ecfa9f9 upstream.
    
    It has recently come to my attention that nvidia is circumventing the
    protection added in 262e6ae7081d ("modules: inherit
    TAINT_PROPRIETARY_MODULE") by importing exports from their proprietary
    modules into an allegedly GPL licensed module and then rexporting them.
    
    Given that symbol_get was only ever intended for tightly cooperating
    modules using very internal symbols it is logical to restrict it to
    being used on EXPORT_SYMBOL_GPL and prevent nvidia from costly DMCA
    Circumvention of Access Controls law suites.
    
    All symbols except for four used through symbol_get were already exported
    as EXPORT_SYMBOL_GPL, and the remaining four ones were switched over in
    the preparation patches.
    
    Fixes: 262e6ae7081d ("modules: inherit TAINT_PROPRIETARY_MODULE")
    Signed-off-by: Christoph Hellwig <[email protected]>
    Reviewed-by: Greg Kroah-Hartman <[email protected]>
    Signed-off-by: Luis Chamberlain <[email protected]>
    Signed-off-by: Greg Kroah-Hartman <[email protected]>

diff --git a/kernel/module/main.c b/kernel/module/main.c
index 7a6f43d2b775..7a376e26de85 100644
--- a/kernel/module/main.c

Display More

and some more after that.

So that patch seems to be incorporated.

TV adapter drivers missing from 11.0.4?

Similar Threads

Official LE12 Test Images for Amlogic (Kodi-21)

HDMI no display after turning off TV overnight