Can you test which part is responsible for your issue? First part is pVideoPicture->iFlag line, second part is if clause and third is rest of the code.
Playback fails if I only use the first part:
pVideoPicture->iFlags |= m_pFrame->data[0] ? 0 : DVP_FLAG_DROPPED;
if (m_codecControlFlags & DVD_CODEC_CTRL_DROP)
{
pVideoPicture->iFlags |= DVP_FLAG_DROPPED;
}There is also another issue - this commit completely broke the playback on DRM PRIME, at least on Intel. I tested with pure Kodi master, no WIP HDR stuff involved.
I tried to increase CMA to 512 but it didn't fix the issue.
I tested only on Gemini Lake board.
Do you have enough CMA? We specify to allocate 256MB.
I did not change CMA:
CONFIG_CMA_SIZE_MBYTES=256I found what's causing graphic glitches in retroplayer. It's something in kernel config options.
No more glitches after I built kernel 5.10 using an older linux.x86_64.conf file from kernel 5.6 (~May 2020).
Will try to figure out what option is causing it.
No, it's only in games. Video and GUI is fine.
Same issue with your build too. Side-scrolling games look jerky:
Interesting. I just built matrix/9b4db0e and glitches are still there. Can you upload your build?
Did anyone try retro gaming on my builds?
I remember there were no issues when I tried some Sega/SNES roms about a year ago.
With current Kodi master I get some serious texture glitches/stuttering. This is something specific to GBM/GLES as official nightlies don't have this issue. Tried to revert some GBM/GLES related commits but can't figure out when the issue started.
Any idea what the pros and cons are with the older drivers versus the new ones?
New Intel hardware e.g. Tiger Lake, Rocket Lake is only supported by the new media-driver.
For Gemini Lake and older I recommend to stay with "legacy" intel-vaapi-driver, at least for now:
LIBVA_DRIVER_NAME=i965On Gemini Lake VP9 10-bit videos don't play when using the new media-driver. I reported the issue here.
I'm not really sure about this. Last time I tested my gemini lake hardware enabled 12bit output.
I was talking about 50/60Hz 4K modes. 12-bit works with 2160p/24/30Hz.
On Gemini Lake 2160p60Hz is only possible with RGB 8-bit (default), YCbCr 4:4:4 8-bit (with a driver hack).
I'm not sure if YCbCr 4:2:0 12-bit could be enabled with a hack or otherwise. 4:2:2 is not supported by the driver.
It is possible to enable GPU dithering for 8-bit modes (with a driver hack). It certainly eliminates the banding on my test videos and looks ok to me.
Deinterlacing is not available when using your build
Switch off "Allow using DRM PRIME decoder" and VAAPI deinterlacing will be available. There is no other way at the moment.
But at the location on the screen where the subtitles should be, is a bar which contains a stretched version of the running movie but only the red portion.
Yes, I can also reproduce this on my Gemini Lake box. An issue with subtitle rendering.
The specs page say that it only supports 2160p at 50/60Hz. Maybe that is the problem?
My question; is it possible to install Libreelec (desgined for RPi 1/B+) on this board.
No.
I have not tested for long, because unfortunately the TVHeadend server on the build isnt working (requires a kernel-module which is not there - most likely due to the kernel-change?) and I needed to watch some TV
Yes, Tvheadend that was compiled for X11 version of LE doesn't work.
I compiled Tvheadend 4.2 and 4.3 that will work with my builds.
