Posts by CroqueMr

Quote from ssft

I've been testing HDR10 Expert on a Samsung S95H (TV peak set to 2600, static tone mapping) with the CroqueMr RC3 build on a 780M box, and a few DV titles look wrong:
- The Shining: washed out, especially the opening aerial shots.
- Ocean's Eleven: black crush in darker scenes.

Switching to HDR10 Basic (or native Kodi) fixes both. Can anyone else reproduce this?

I had Claude Code go at it with a private build and some additional debug logging, don't know if it's on to something or not:

Expert applies the CM2.9 L2 slope/offset/power in linear nits normalised to the TV peak: T * clamp(in/T * slope + offset)^power. Because the offset is multiplied by T, a tiny trim becomes a big black-level shift at high peaks:

┌────────────────┬───────────┬─────────────────────────────────────────────┐
│ title │ L2 offset │ effect at T = 2600 │
├────────────────┼───────────┼─────────────────────────────────────────────┤
│ The Shining │ +0.0033 │ +8.6-nit black floor (washed out) │
├────────────────┼───────────┼─────────────────────────────────────────────┤
│ Ocean's Eleven │ −0.0006 │ everything below ~1.6 nits crushed to black │
└────────────────┴───────────┴─────────────────────────────────────────────┘

(Offsets are the values CB1 resolved for a 2600-nit target, offset = code/4096 − 0.5; e.g. code 2061.5 → +0.0033.)

With nothing changed except skipping the L2 trim step, both titles looked normal. With trims applied they were washed out or crushed.

Display More

Thanks for the feedbacks, I am working on a more precise conversion a real LLDV over HDR10, it will replace HDR expert conversion at target.

Quote from jdrch

Overkill is my middle name. This is literally my 6th external player in my home theater cabinet. Also why I introduced myself as parachuting in from AVSforum where overkill is a way of life.

I don't want any test failures with the GUI on (see the results  CroqueMr posted). The more horsepower I have that can just brute force that, the better. FTR - and I think this point seems to be lost on folks used to inexpensive Amlogic devices - DV7 FEL is not computationally easy. Doing it in software is so taxing even a 3rd Gen Apple TV 4K can't do it and Atmos height channels simultaneously:

I want to be able to do 4K60 (e.g. Gemini Man) with the GUI and all audio channels.

FEL is not a big issue, and we are not doing the maths in software/CPU, we use the shader of your iGPU to upscale the FEL and process all the picture. The big bottleneck is the 60fps. I will add the 7430U to my benchmark to have a better lock on requested performance to have no drops even with GUI

Quote from Silver11211

Thank you so much for your work. Ive tried RC2 on a rtx 3080 and it works pretty well except that the player freezes when i bring up the dv mode screen (double pressing O). That is on a fel movie, mel doesnt have it. Also black screen after closing a video but i think it can be my hdmi cable.

Please send me the log, and could you try the RC3 preview and tel me if you have the issue?

Quote from sunlollyking

CroqueMr Awesome work - Apologies did you see my message about the GL version and whether it's something we could add to your backlog ?

yes here : RE: Dolby Vision w/FEL + 3D for PC (AMD/Intel/nVidia)

FYI : From now on, I'll gradually add fixes and features to the next build. Once enough changes have accumulated, I'll clean up the code, optimize everything, and push a new release.

The RC3 preview is already available here https://github.com/CroqueMr/libre…0.0-RC3-Preview

Feel free to check it out and let me know if it meets your expectations, especially the CM 2.9 to 4.0 information, HDR10+ settings, stability fixes, etc.

Changes since R1.0.0-RC2

Dolby Vision

• Added GPU bilinear FEL upscaling, replacing the nearest-neighbor fallback when VAAPI scaling is unavailable.
• Added the Reference GPU FEL filter as a selectable option for other conversion modes. Master Reference retains its reference filter.

Playback and stability

• Fixed cases where stopping playback during a resolution change could leave HDR signaling active instead of returning to SDR.
• Fixed stale HDR10 session reuse after a rejected output activation, ensuring subsequent playback prepares the required output surface.

Settings

• Separate remembered rendering preferences for Dolby Vision, HDR10 and HDR10+ inputs.
• Automatic fallback no longer replaces the preferred rendering mode.
• Fixed rendering options incorrectly remaining unavailable after stopping a different source format.

HDR10+

• Fixed source-specific preference selection during continued HDR10+ playback, preventing accidental use of the plain-HDR10 preference.

Player information

• Corrected misleading "Unused blocks" reporting: metadata forwarded to the TV is no longer marked unused.
• Displays whether CM2.9-to-CM4 conversion is actually active, including live updates for Auto and Auto 2.

Blu-ray menus

• Updated BD-J Java add-on packaging with matching libbluray 1.5.0 support files.
• Prevented stale or incomplete Java support files from being packaged. Requires the updated JRE add-on attached to this release.

Yes not having a didicated hdr10+ default setting was a mistake. It has been added for the next release

Quote from ashlar

Hrrmmm... tried the new RC2 release.

I suggest having settings for DV conversions the same way as the AmLogic builds have.

If I select HDR10+ ---> DV during a HDR10+ movie, it works. I stop the movie, I play a HDR10 movie and it outputs as HDR10, even if in settings I set HDR10 to be outputted as Dolby Vision.

One setting for Dolby Vision, one setting for HDR10, one setting for HDR10+. During these early days it's fine and dandy to want to test everything. But for real usage I think one wants to configure it once and not have to fiddle in real time for every video started.

I also noticed that SDR videos do not respect limited output setting. My OLED tv is calibrated to 16-235, so I need limited video levels. I set them in the System/Video settings page and for HDR/DV content they are respected. If I play a SDR video, black becomes gray. Tested this with patterns as well, like the classic one with grey bars and black should be at level 16. I see instead grey bars far below 16. Something is amiss.

I also keep on seeing HDR videos blanking the screen intermittently. I have already sent a debug log to CroqueMr about this, I don't know if he has had a chance to look at it. I'll most likely test tomorrow with the official build to see how the situation is over there. I am starting to be very afraid that my NUC 11 i3 might be a lemon of sort. It takes ages to switch screen mode/refresh rate, far longer than what happens with AM6B+ or my HTPC. It often gets the "no signal" screen from my LG tv set. Something I never see happen on either AM6B+ or HTPC.
I was so enthusiastic about this whole development that I bought a fanless case for it before even testing the builds... but everybody seemed so happy. You live and learn...

Display More

No worries, HDR10+ is not yet perfect and some of your issues as already been fixed for RC3. Normaly last settings is saved and will be applied to your next playback. And if the rendering output is not correct you can switch the mode on the fly during your play back, press "O" twice to have the quick pannel settings

For SDR and limited video the fix will be simple.

For the support of your NUC please open an issue on github it’s much easier for me to keep track of everything this way. If necessary, I just finished my build with remote access that allows me to make on-the-fly fixes and investigate any hardware issues directly on your minipc. This build is private, of course, and includes all the required consent disclosures. We can go that route if needed and if you agree.

Quote from sunlollyking

CroqueMr

First off, thanks for RC2. It's on my 780M box now and it's looking really good.

I wanted to ask whether you'd consider supporting the OpenGL build of LibreELEC (the Generic.OpenGL device, with Kodi built for GL) as well as GLES.At the moment Dolby Vision only works on the GLES image, so I have to choose between DV for films and the GL image for games. A lot of my time goes into Kodi's game player (RetroPlayer), and some cores and shader presets only work, or only work fully, on desktop GL. It would help beyond LibreELEC too. Most desktop Linux builds of Kodi (distro packages, the flatpak) use GL rather than GLES, so a GL path is what would let your work reach those users, and anything aimed at Kodi itself would need it as well.

What I think it would take, from going through the RC2 patches: most of the Kodi side isn't tied to GLES, but about 6.5k of the ~23k lines sit in GLES-only classes that a GL build never compiles:

DVBridgeGLES (~2.9k lines)

WinSystemGbmGLESContext (~2.7k)

RendererVAAPIGLES, LinuxRendererGLES and OverlayRendererGLES, plus small bits in RendererDRMPRIMEGLES and the GLES screenshot and filter shader code

A GL build uses WinSystemGbmGLContext, RendererVAAPIGL, LinuxRendererGL and OverlayRendererGL instead. The way I'd approach it:

Move the DV/HDR output and DRM handling out of WinSystemGbmGLESContext into WinSystemGbm, or a helper both contexts share.

Make the DVBridge renderer API-neutral. libplacebo's OpenGL backend takes either a GL or a GLES context, so it should mostly come down to small GL and GLES shims for the EGL image import and the shader headers.

Mirror the VAAPI, LinuxRenderer and overlay hooks in their GL counterparts.

Add a Generic.OpenGL build so the GL side doesn't drift.

I'm happy to help with the Kodi side and to test GL builds on the 780M and know some others who would too.

Cheers,

Display More

I need to check, maybe it will be a fork not supported once the stable release is finished

Thanks for the kind words,

Yes 60fps is difficult to render, but the two most important circuits are perfectly stable on the two small CPU : Master Reference & DV to HDR10 Expert. I’ve spent the most time optimizing them, if I have a bit less support work to do, I could push the optimization further for the rest, but it will not be a game changer

Quote from Creator44

Found a little bug but it's related to using plex4kodi like I do, when I start my HDR10+ video from the beginning and ask for hdr10+ to dv the video does not start. If I resume it works and if I play from beginning or resume directly in kodi it works.

Also, when the credits started because I let the movie play while doing something in the background, at some point I got a message that HDR10+ not available or something and it went back to standard HDR10.

Finally, in the player process infos, when you ask for hdr10+ to dv, even on HDR10 normal I get messages that says it could not do DV Reference AI. The playback seemed ok in normal HDR10.

Can you send me the log with all your issues inside? I will check what I can do.

Here is a short benchmark to give you an idea of how two small CPUs perform. Take a look at the specific circuits you're interested in. I’ve included a table covering the GUI, it’s not a huge deal for me personally, but apparently some people really hate experiencing frame drops when a Kodi graphical element is on screen. (these aren't the subtitles, it is Kodi overlay)

Quote from Creator44

Thank you for the explanation, I will go with IPT as my mini pc is sleeping at 25% usage on the render engine.

I tested all 5 transformers movies that didn't work before and they all work perfectly now, thanks!

I tested the PGS subtitles brightness and it's working and this is gonna be a lifesaver I find the full white subs too agressive for the eyes. I am surprised that 5% is still quite bright in the sense that I expected to almost not see them but that's not a problem they are still quite dark. I'll probably use 50% or something.

I checked the player process infos and the dots (...) are gone so thank you! I also appreciate others asking for something I wanted, seeing the channels count instead of RAW, RAW, RAW which is useless. I think the only thing that is missing is the fact that we don't see if the CMv2.9 to CMv4.0 is happening or not in the player process infos but that was already asked.

Tested HDR10+ to DV with a HDR10+ only file, seems to work fine I get a scrolling "AI estimates; authored curve not translated text on player process info."

I saw a tool mkvdovi can translate the HDR10+ to DV 8.1, I wonder if that would be better or not since it analyzes the picture completely, maybe that authored curve thing that your conversion skips? Maybe it can be added later? In any case it looks good already. Thanks!

Display More

Glad you're happy with the addition.
For HDR10+ conversion to DV, this is a first approach, I need to refine my algorithm, It doesn't meet my standard, we lose some informations (It’s normal, we’ll always lose some, but I’m sure we can do better). I think, I will train a dedicated AI, like I did for HDR to DV conversion and add the model in the build.

I will work on HDR10+ deeply next week.

And also a complet rebuild of the player info panel is planned, this was just some small adjustment

Quote from Khazar

hadesdevls  CroqueMr

ok so now both forks are getting stuck, Hades installs itself and after the reboot the same window with the LibreELEC version gets stuck.

The only thing that changed(since the last time I successfully started Hades with zero problems), is that I installed the newest hotfix NVIDIA drivers and I removed the overclock on my GPU.(so one Windows thing and something that should increase stability, not create more problems...)

Could it be the driver update that causes these problems?

The only .log that was created with Hades fork is the "fs-resize.log", I'm gonna assume that's just for the install start and not the real first run?

No it's not linked, I used some code from Hades in the RC2, this is why we have the same behaviour, I will check with my 5090 this week what is happening, it will be fixed for RC3.

Quote from Creator44

Quick question: Does the YCbCr vs IPT only change the format sent to the TV and not the PQ? Is the PQ completely identical? DMDReviews seemed to say the standard way is to sent IPT so I switched it to that but not sure if it changes anything in the end?

The selector YCbCr / IPT is only available for Master Reference output, Standard output (now called Reference) use YCbCr

To be simple, if you select (except for Profile 5 that is always send in IPT because the file is in IPT) :

- IPT as prefered output, in master reference the conversion YCbCr -> IPT will be performed by your PC,

- YCbCr as prefered output, in master reference the conversion YCbCr -> IPT will be performed by your TV

Using YCbCr means one less conversion step on the PC side, shifting that task to the TV instead, which helps small iGPUs. Your TV should handle the conversion perfectly, so you shouldn't notice any difference, however, if your PC is capable enough, you can opt for IPT, which ensures the conversion is performed with high precision right on your PC.

Quote from MrMagic

In the re-release of RC2 PGS subtitles work correctly again, thank you.

I have a request regarding them. This is already in a test build of avdvplus R11:

Would it be possible to allow PGS subtitles to be moved up and down on-the-fly when manual positioning is enabled? This already works for text-based subtitles while watching a video by binding remote keys to the "subtitleshiftdown" and "subtitleshiftup" actions.

I can check that

Quote from Khazar

NVIDIA 5090

P.S. sorry have to wait 40 mins after each post

I will check with mine next week, It’s probably due to some additions I made to the drivers.

Quote from MatteN

Didnt do any changes what so ever other than uppdating.

But on the previous version your had less drops/lags?

Quote from MatteN

J5040 struggles a bit on Avatar The Way of Water at Master Reference, Reference is quite ok.

https://paste.libreelec.tv/chalkiest-niels.log

Do you use IPT or YCbCr Output for master reference, did you see a regression in term of performance? with master reference in beta5 vs RC2? IPT is far more stressful for your iGPU than YCbCr

Quote from nissel

Installed and working well here. Some feedback on the new features of RC2:

1. Could the HDR10+ option be separate from the HDR10 options, as you can't currently config HDR10 to DV and HDR10+ to DV without changing it during playback. Also the menu entries in settings remain flagged as (unavailable) based on the previous playing file which is confusing.

2. Is it possible to show if the CMv4 convertion is active in the PPI? Preferably updating live if one of the auto modes is in use.

Thanks

Yeah np I will add that for the RC3

Quote from Khazar

CroqueMr sadly getting the installer USB-Stick to properly boot is proving to be a problem.

2 different USB-sticks so far have failed and get stuck on the "LibreELEC (Community): DV RC2" screen that comes after the logo.

The only thing that worked once(also taking like 3 reboots and drive reformats) was the USB SSD, which I need for the OS at the end though.

So if you could ever offer a way to directly install it to the already correct device without a middle device, just like Hades, that would be great.

For now I literally cannot get this version to work.

Display More

What is your GPU ?