Posts by HiassofT

Quote from Killom

Changelog available?

Here's my dev branch that I used for this build: https://github.com/HiassofT/LibreELEC.tv/commits/480810e - lots of kernel and ffmpeg fixes and deinterlace and HDR patches for kodi.

so long,

Hias

Quote from Killom

Connected TV to HDMI0 and Audio Extractor to HDMI1. On booting the picture delivered by RPi 4B is too bright.

When booting without Audio Extractor on HDMI1, the brightness is good.

This is a known issue of LE10.0.1 and will be fixed in LE 10.0.2.

You can give this build https://www.horus.com/~hias/tmp/libr…422-480810e.tar a try, it includes all fixes and improvements we got so far.

so long,

Hias

Quote from frakkin64

Should both pull down & double refresh rate be used? It looks like it is jumping between 59.94 and 60, which I wouldn't have expected with on start/stop as the adjust refresh option.

Pull-down is only needed for 24->60 Hz, you can keep it disabled if your TV suports 24fps. You should enable double refresh rate though (and disable 25/29.97/30Hz in whitelist) to get proper output with interlaced contents.

Regarding the black screen/refresh rate changes: can you please upload a sample file that shows this issue?

so long,

Hias

Thanks for the report, I can confirm the issue. Our good old friend "flip_done timed out" is back - I already pinged RPi devs.

so long,

Hias

The changes are included in nightly builds for a while now so it should work - but keep in mind we can't test it as we don't have the necessary hardware.

So if it doesn't work please do a clean install of latest nightly first and post details (logs, etc).

Feedback if it works with latest nightly would be good, too

so long,

Hias

FYI: the 10/12-bit video output patches have been merged into the master branch and will be included in the next nightly build (20211219) - please use those for testing when they are available as they include other fixes as well (eg for deinterlace).

If you prefer to stay on LE10 here's a first LE10 testbuild with 10/12bit video output and deinterlace patches (plus lots of other fixes, too):

https://www.horus.com/~hias/tmp/libreelec/LibreELEC-RPi4.arm-10.0-devel-20211218214422-480810e.tar

It would be great to get some feedback on the LE10 testbuild as well, initial testing here looked good, but we'd like to have some more positive confirmation that things work as expected before adding the backport patches to official LE10 releases.

so long,

Hias

Quote from marantz

is it resonable to backport this to v10?

Yes, we plan to include this in v10 as well after testing is finished.

so long,

Hias

Quote from HomerJau

Does this mean we’ll see LE11 HDR testbuilds for generic (Intel) versions soon too?

Sorry, no idea if additional changes might be needed for Generic.

We added the kernel patches to add support for 10/12bit video output in the driver and a small kodi patch that signals the driver to outut 12 bit, if possible (via the max_bpc DRM property which is also present on Intel and other video drivers).

Here's my current dev branch with all changes (kodi patches are only applied for RPi but colourspace and max_bpc patches should work on Intel, too): https://github.com/HiassofT/LibreELEC.tv/commits/le11-test

so long,

Hias

camelreef the important bits in the edid are that it contains support for YCbCr 4:2:2 support in the CTA extension block (pretty much any HDMI TV should support that):

Block 1, CTA-861 Extension Block:
  Revision: 3
  Underscans IT Video Formats by default
  Basic audio support
  Supports YCbCr 4:4:4
  Supports YCbCr 4:2:2

And for deep color (10/12bit RGB 4:4:4) the DC_30bit and/or DC_36bit bits should be contained in the HDMI vendor block:

  Vendor-Specific Data Block (HDMI), OUI 00-0C-03:
    Source physical address: 4.0.0.0
    Supports_AI
    DC_36bit
    DC_30bit
    DC_Y444

In addition to that the edid also should contain an HDMI Forum vendor block which announces support for TMDS rates up to 600MHz to get RGB 4:4:4 at 4kp30 with 10/12 bit or YCbCr 4:2:2 12bit at 4kp60 - at 300MHz TMDS rate the max is 1920x1080p30 at YCbCr 4:2:2. eg:

  Vendor-Specific Data Block (HDMI Forum), OUI C4-5D-D8:
    Version: 1
    Maximum TMDS Character Rate: 600 MHz
    SCDC Present

so long,

Hias

Yes, we tested it, and I missed that deinterlace is broken - just noticed it now We're already working on it.

To verify output mode you could check if your TV/display has some kind of diagnostics / info menu. My LG C8 is unfortunately a bit too old and only tells me resolution and refresh rate - newer models should also report color format and bit depth.

popcornmix checked with his HDMI analyzer and we both checked dmesg - with drm.debug=0x02 you'll see the mode and bit depth buried in tons of other logs, eg

[   73.507849] vc4-drm gpu: [drm:vc4_hdmi_encoder_atomic_check] Mode 3840x2160 @ 60Hz: Found configuration: bpc: 12, fmt: YUV 4:2:2, clock: 593407000

or

[  152.031004] vc4-drm gpu: [drm:vc4_hdmi_encoder_atomic_check] Mode 3840x2160 @ 24Hz: Found configuration: bpc: 12, fmt: RGB, clock: 445054500

so long,

Hias

If you are in the mood for some experimental testing here's a first LE11 testbuild with 10/12bit output support

https://www.horus.com/~hias/tmp/libreelec/LibreELEC-RPi4.arm-11.0-devel-20211216212118-cdca5e3.tar

If you play a 10bit video file the video driver should select the best mode supported by the display: RGB 12bit is preferred, then YCbCr 4:2:2 12bit, then RGB 10bit and if none of that is supported by the display RGB 8bit is used (as before).

Note: this is a LE11 testbuild with kodi Nexus so better install it on a separate SD card if you're running LE10 and don't want to trash that installation.

so long,

Hias

Update to LE 9.2.x or see here if you wish to stay on 9.0.x: RE: Cannot Install/Update Addons

so long,

Hias

FYI: there's no need to unsquash/update/squash SYSTEM to add/update wifi firmware, simply drop it in /storage/.config/firmware/brcm (you need to create that directory first) and reboot

so long,

Hias

yullaw thanks a lot, this is very interesting. So it seems your TV doesn't like the initial "handover" from firmware to linux graphics driver if the resolution isn't changed.

I hope this observation will help RPi engineers to find a solution, maybe there's some timing related issue (random guess).

so long,

Hias

You can fix it by booting from SD, either with LE or the eeprom recovery image.

so long,

Hias

Are you booting from USB or network? If yes, then ENABLE_SELF_UPDATE=0 will surely prevent updating, it needs to be set to 1.

so long,

Hias

The patch was included in the 5.10.80 kernel about 2 weeks ago and should be in the next LE release (nightly builds should already have it for some time).

so long,

Hias

Tim was quick, we already got a fix, PR with rpi-eeprom update is here https://github.com/LibreELEC/LibreELEC.tv/pull/5936 and should be in nightly builds soon.

so long,

Hias