I've got some initial commits here: Comparing LibreELEC:master...milhousevh:le90_init_sky42_patches · LibreELEC/LibreELEC.tv · GitHub
Can you review the changes and post back in this thread. I know there are three threads discussing different suggestions which are all bundled up in the one branch but keeping the discussion on topic in each of the threads might make things easier.
Nice, just need to test it thoroughly now!
I've got some initial commits here: Comparing LibreELEC:master...milhousevh:le90_init_sky42_patches · LibreELEC/LibreELEC.tv · GitHub
Can you review the changes and post back in this thread. I know there are three threads discussing different suggestions which are all bundled up in the one branch but keeping the discussion on topic in each of the threads might make things easier.
I think this is a valid issue, and a quirk of the img update mechanism, so I'll look into fixing this. Unfortunately as with anything that touches init even trivial changes usually require a disproportionate amount of testing so it's a good thing you can self-build. 
marc.bau can you test with a recent LE9.0 build
Some of the errors you are seeing ("Connection timedout" etc.) can be triggered by SMB chunk size which has been reduced in late Jan 2018 from 1MB to 64KB in order to improve BD ISO performance.
We are experiencing some bugs in latest LE9/Kodi 18 test builds but please give it a test and see if your experience with SMB is any better/worse/unchanged.
Can you tell me more about what you are doing with post_flash() and post_update(), and why they are needed? I'm wondering if they need to be additional boot steps but could be added at the end of mount_flash() and mount_storage(), which would mean post_update() is called before check_update().
The days of SD corruption are long behind us, thankfully, so these days there really should be little reason to use the ramdisk in order to avoid accessing the SD card.
You can also boot over NFS (although with the pre-v1.2 RPi2 you'll still need an SD card with bootcode.bin). init: mount per-client boot/disk if available & configured by MilhouseVH · Pull Request #621 · LibreELEC/LibreELEC.tv · GitHub has some details on how this can be accomplished.
I haven't looked into whether a ramdisk is beneficial when booting over NFS - copying the SYSTEM image into RAM might possibly result in improved performance and might be worth investigating (your SYSTEM_TORAM_LIMIT patch would be useful as a method to enable ramdisk support when it would otherwise be disabled - you could just set SYSTEM_TORAM_LIMIT=0 to force it).
My source code I have in my personal git server.
The idea would be to use a public git repository (which is actually a Community Build requirement - that your code is published).
How can I contact LibreELEC Odroid Developers if I have questions for features I make before sending to project?
You can use the Amlogic forum - post questions/ideas and you should get a response. If you use a public git repo you can link to your branch when discussing code, ideas or problems.
Thanks for the suggestions, will think them over.
How much of a benefit do you see when using RAM for Storage? To be honest I'd be inclined to drop this feature entirely as in testing (several years ago with OpenELEC) there was little obvious performance benefit, and it just wasted a chunk of RAM (100MB or more).
To rule in/rule out the RPi firmware, can someone copy the following firmware files from 8.2.5 to their 8.2.3 installation and see if they start to experience the same issue:
/flash/bootcode.bin
/flash/fixup.dat
/flash/start.elfHave you tried the latest LibreELEC 9 as Kodi 18 now has improved domain support after PR13725.
I don't think we are likely to implement explicit support for AD domains.
Note that network browsing ("seeing shares") is a feature dependent on SMB1 which no longer works now that many vendors (including Microsoft, and LibreELEC) are disabling SMB1 by default.
ssh -vvv root@@192.168.2.153
Is the double-@ a typo?
Are you sure the IP address is correct?
Can you ping the device?
Is Samba enabled and working?
Can you downgrade to the previous version (using either Samba, or the built-in upgrade mechanism)?
Does ssh work again with the previous version?
I know of no particular reason why ssh should stop working, unless the configuration is corrupted, or ssh is not starting (crashing?) Very occasionally this type of issue is reported but clears up with a reboot or the next upgrade (which doesn't make much sense, but I suspect it's the reboot that fixes it not the upgrade itself).
Billzilla Can I suggest you read the section "SAMBA / SMB CHANGES" in the release notes:
LibreELEC (Krypton) v8.2.1 MR – LibreELEC
In particular the bullet point relating to "anonymous and guest shares" as you must now create a user with password in Windows 10 and add this user to your Windows 10 share ("the share account") then configure Kodi on LibreELEC with the username and password of your Windows 10 share account.
If you've managed to setup a Windows share then you should now be able to add the required user, allocate it to the share you've already created, and then configure Kodi accordingly.
Please be aware that the problem you are experiencing is not a LibreELEC issue - it's a problem caused by your Windows PC that you have updated and which you are responsible for.
stacsmax53 Samba Network Browsing hasn't been supported for a long time as it depends on SMB1 which is no longer supported by Microsoft in Windows 10 (unless you enable SMB1 yourself, which is not recommended by anyone including Microsoft).
The reason it wasn't suggested is because your initial post gave no indication that network browsing was remotely part of the problem - on the contrary you gave the impression that network browsing is actually working ("Windows network sees them as part of 'workgroup'" etc.), although that might suggest you have SMB1 enabled, which is why I asked if you had the Fall Creators update (as this will disable SMB1).
This is the biggest problem when trying to solve Samba issues - there are just too many moving parts and when a user gives insufficient or confusing information it becomes even more difficult to work out why devices and services in the users network do not work together.
So please, don't try and suggest this is our problem for not helping you. Thanks.
vpeter: If you believe there to be any inaccuracy then by all means post more detail, however you haven't been present on LibreELEC Slack for several months (your choice) so you may not be aware of all the drama prior to Adam making the decision to quit Team LibreELEC. However, I'm sure you're aware of the derogatory comments subsequently made on other forums so I'm really not sure what issue you have, unless you believe Adams side of the story (hint: don't).
As for the events of today, they are exactly as described and we are investigating what needs to be done under EU regulations.
Indeed, blueribb has it spot on - what is the client OS, you've told us it's Windows 10 but which version - is it with or without Fall Creators update? And what Is the "media system", is this your LibreELEC client?
Windows 10 with Fall Creators update no longer supports anonymous access (or SMB1) by default, so if you're using a Windows 10 machine with Fall Creators update to access a LibreELEC share then in the LibreELEC Samba Server enable authentication, and ensure the minimum protocol is set to SMB2.
If it still doesn't work then there's a mismatch somewhere in your network between minimum Samba protocols, and authentication requirements.
At the moment I think it's a case of waiting until the tipping point, i.e. when the majority of Windows (or other) installations require authentication then it makes sense for it to be enabled by default in the LibreELEC Samba Server. At the moment only Windows 10 users with the Fall Creators update (released Feb 2018) require authentication by default, which leaves a vast number of Windows (and non-Windows other) users that do not require authentication by default.
Perhaps closer to the time of LE9 release this can be reviewed - admittedly the Fall Creators update has been quite, erm, "popular" thanks to Microsoft essentially forcing it on Windows 10 users, so it may be the case that Win 10 + FC will have exceeded 50% share later in the year (at the time of writing total Win10 market share is about 46%).
So, yes, authentication is likely something we can enable as the default in *new* installations of LE9, but IMHO the timing isn't quite right for LE8. Also, the authentication setting is unlikely to be changed for *existing* LibreELEC installations when upgrading to LibreELEC 9 - after all, if the old LibreELEC installation doesn't need to be authenticated then nor will their new upgraded LibreELEC installation.
And finally, if users do something beyond our control and upgrade their Microsoft client (ie. Windows 10) so that it suddenly starts requiring authentication and subsequently fails with an obscure "Operation not permitted" error, there's very little we can do about that - it's up to the user to now reconfigure their LibreELEC Server to match the security requirements of their newly upgraded Microsoft client,
However I'm sure we will get used to answering posts in the forum when users mention "SMB", "Windows 10" and "Operation not permitted". Answer: "Enable authentication in the LibreELEC Server".
As with anything which involves migrating users to increased default security, it will take time for most users to make the transition, and the early days will be the most painful.
It would suit LE to have a default libreelec/libreelec user/pass, instead of just failing.
That *is* the default username/password for the LibreELEC Samba Server.
Changing this password to something stronger is a good idea.
I went to settings and changed SMB1 as min, and SMB3 as max. Didn't work either.
What SMB min/max settings did you change?
The settings you need to change are Settings > Services > SMB client (you'll need to ensure Advanced or Expert mode). The default settings this will connect to SMB1, SMB2 and SMB3 servers, so really doesn't need any changes when connecting to a Windows 10 server.
What isn't supported by LibreELEC is anonymous access to shares (and this also isn't supported by Microsoft in Windows 10 - it was dropped a few updates ago). You'll now need to create a user account on your Windows 10 PC and assign it to your share, then enter the username/password of the account into Kodi when prompted (ie. when you access the share).
Browsing the network (WORKGROUP > THE-COMPUTER etc.) no longer works reliably as it depends on SMB1 and, with this being disabled by default by most vendors (including Microsoft), the ability to browse the network using Samba is not expected to work. You must now add your SMB network with "Add network location...", then add your source.
Finally, enabling SMB1 in Windows 10 is a bad idea - Microsoft had very good reason to disable it.
