Posts by hdkiller

Hello guys!

Latest GFE breaks moonlight streaming under 2.4.5

New Windows/GFE update breaks Moonlight? (RTSP: Failed to connect to UDP port 48010) · Issue #609 · irtimmer/moonlight-embedded · GitHub

Thank you very much.

v2 also works.

Yes I can test later today. I will let you know.

Honestly i dont remember what is the difference between those?

Your latest one is flawless so far 107

It works!! Thanks a lot!

Hello!

So when I set Wireless Access Point on and do a reboot, I don't have name resolving since the routes for the DNS servers are inproperly set. Then if I go to libreelec settings and disconnect wired ethernet and then connect wired ethernet the name resolving works:

Ubuntu Pastebin

Thanks!

These are the addon PR's:

Update moonlight embedded wrapper to 2.4.3 by stefansaraev · Pull Request #47 · dead/script.moonlight · GitHub

make parameteres compatible with moonlight 2.4.3 by hdkiller · Pull Request #48 · dead/script.moonlight · GitHub

CvH has the LibreElec patches

@seo and vpeter found the solution on IRC.

Moonlight.py had to be updated to reflect the changes made in moonlight:

diff --git a/script.moonlight/lib/moonlight.py b/script.moonlight/lib/moonlight.py
index 7edae39..154521b 100644
--- a/script.moonlight/lib/moonlight.py
+++ b/script.moonlight/lib/moonlight.py
@@ -10,6 +10,14 @@ GS_WRONG_STATE = -4
 GS_IO_ERROR = -5
 GS_NOT_SUPPORTED_4K = -6
 
+class DISPLAY_MODE(ctypes.Structure):
+    pass
+
+DISPLAY_MODE._fields_ = [("height", ctypes.c_int),
+                         ("width", ctypes.c_int),
+                         ("refresh", ctypes.c_int),
+                         ("next", ctypes.POINTER(DISPLAY_MODE))]
+
 class SERVER_INFORMATION(ctypes.Structure):
     _fields_ = [("address", ctypes.c_char_p),
                 ("serverInfoAppVersion", ctypes.c_char_p),
@@ -20,8 +28,11 @@ class SERVER_DATA(ctypes.Structure):
                 ("gpuType", ctypes.c_char_p),
                 ("paired", ctypes.c_bool),
                 ("supports4K", ctypes.c_bool),
+                ("unsupported", ctypes.c_bool),
                 ("currentGame", ctypes.c_int),
                 ("serverMajorVersion", ctypes.c_int),
+                ("gsVersion", ctypes.c_char_p),
+                ("modes", DISPLAY_MODE),
                 ("serverInfo", SERVER_INFORMATION)]
                 
 class APP_LIST(ctypes.Structure):

The SSL patch still needed.

I will update the addon.py in the next following days to include the new parameters and remove the controller mapping section and check pairing too.

Thank you all the help you guys provided.

Thanks guys!

I was trying v3 and well, it way much better than was. I was able to open the app list serveral times before it's crashes. I tought this will solve the crash too but it's seems like it's still happens but much rearly. I tired loading the lib with python and now it's successfuly loads. So that OpenSSL problem is gone.

Here is a gdb output as vpeter suggested yesterday when the crash happens: WCYF

Hello!

I was debuging addon.py and it's seems like the kodi crash happens when the code reach xbmcplugin.endOfDirectory(addon_handle)

script.moonlight/addon.py at master · dead/script.moonlight · GitHub (line 69)

I don't really understand what's going on, i have debuged and it's connect to moonlight, fetch the apps, posters, etc So maybe that EVP_CIPHER_CTX_new not relevant at all, since when kodi calls addon.py it doesn't throw that error.

Anyway, if the gs.connect_server() called, it works, but at the end, kodi crashes. So I removed from the addon all references to LibGameStream and manually added just one item, that way it works. So maybe it's really some compiling issue.. At this point i am going to give up and live with this workaround.

LibreELEC:~/.kodi/addons/script.moonlight # python
Python 2.7.13 (default, Aug 29 2017, 10:07:52) 
[GCC 6.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import ctypes
>>> ctypes.cdll.LoadLibrary("./lib/libmoonlight-common.so")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/ctypes/__init__.py", line 440, in LoadLibrary
  File "/usr/lib/python2.7/ctypes/__init__.py", line 362, in __init__
OSError: ./lib/libmoonlight-common.so: undefined symbol: EVP_CIPHER_CTX_new

Could you please check this out? Maybe the addon isn't build properly?

I have tested the new .zip it's works!

It's crashes like the previous one when I stop a stream and enter again to the game listing, but that problem was existed and it's not a new one.

Thank you very much!

Any idea how to troubleshoot the crash when I launch the addon again after a stream stopped?

This is the log file about the crash what happens when i try to list the games. Seems like after the crash if I hard reboot the PI3 then it works again.

JNfI

I can't test today but tomorrow I will.

Also there is some issue with the listing Kodi still randomly crashes when I launch the moonlight addon to list the games. I will provide logs too by tomorrow.

Plus I believe I should spend some time to understand the current parameters for moonlight and review the launcher addon and that moonlight.sh, because as far as I see it doesn't respect everything I set in the UI.

Unrelated but some games doesn't have proper xinput implementation, but I figured out it's possible to set some controller emulation in Steam Big Picture, when those set those games works properly as well.

Actually this moonlight-streaming on a Pi3 with Ethernet works surprisingly well. I can't tell I am not playing on localhost honestly I am a bit shocked.

Could you please help me out where I can find the addon log file set in the moonligh.sh ${ADDON_LOG_FILE} ? I had to hardcode it to have logs, but I belive there is an easier way to enable logging.

Thanks

Laszlo

See attached file for details.

Let me know how to proceed.. I belive the addon should have some updates aswell..

Thanks guys, now everything works!

I had to edit ~/.kodi/addons/script.moonlight/moonlight.sh and do the following changes:

                if [ "$MOON_FRAMERATE" = "60" ]; then
                        MOONLIGHT_ARG="$MOONLIGHT_ARG -fps 60"
                else
                        MOONLIGHT_ARG="$MOONLIGHT_ARG -fps 30"
                fi

                # if [ "$MOON_FORCEHW" = "true" ]; then
                #       MOONLIGHT_ARG="$MOONLIGHT_ARG -forcehw"
                # fi
               
                # if [ "$MOON_MAPPING" != "" ]; then
                #    MOONLIGHT_ARG="$MOONLIGHT_ARG -mapping \"${ADDON_DIR}/share/moonlight/mappings/${MOON_MAPPING}.conf\""
                # fi

(Remove forcehw param and change the -fps params)

So with all these modification your zip works:

- change library links in ~/.kodi/addons/script.moonlight/lib/moonlight.py

- wget the latest gamecontrollerdb.txt to ~/.config/moonlight/gamecontrollerdb.txt

- comment out forcehw and change the fps in the launch script ~/.kodi/addons/script.moonlight/bin/moonlight.sh

- systemctl restart script.moonlight.service

Now everything works so far as I expected, controller, streaming etc.

I have also found the reason for the kodi crash when the addon tries to list the games on the host, but I don't know how to fix it, but it's reproducable. If there is no name resolving (no working DNS set) then kodi crash when I launch the moonlight addon on the GUI. If I set a DNS then the listing works properly.

How should I process to make these changes avaiable for others in the upcoming updates?

Thank you,

Laszlo

I am on track.. i have edited the moonlight.sh seems like that causing the propblem it's need to update the code

I stuck with:

Can't open configuration file: rcehw

moonlight runs in console but the current plugin throws this:

09:54:13.265 T:1858073504   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!                                            Error Type: <type 'exceptions.OSError'>                                            Error Contents: /storage/.kodi/addons/script.moonlight/lib/libmoonlight-common.so.0: cannot open shared object file: No such file or directory

so i edited ~/.kodi/addons/script.moonlight/lib/moonlight.py and changed:

LibreELEC:~/.kodi/addons/script.moonlight/lib # cat moonlight.py |grep so        self.commonlib = ctypes.cdll.LoadLibrary(os.path.join(libpath, "libmoonlight-common.so"))        self.gslib = ctypes.cdll.LoadLibrary(os.path.join(libpath, "libgamestream.so"))

but still no luck, it's possible to list apps "sometimes" from kodi, but i can't stream, i will try it from console since i didn't found any logs.. but kodi propably crashes when i try to stream

I had to download gamecontrollerdb.txt to ~/.config/moonlight

then systemctl stop kodi

and after that i can start from console and works as expected including the controller now mapped properly

so i belive the problem is somewhere within the launcher but atleast the streaming and the controller works properly

How should I progress to find the reason why kodi crashes when I try to start the stream from the UI?