Posts by shanemeagher

Apollos andy5macht,

I've had a chance to do a little more on my comskip addon. It now has:

- a comskip.ini file included

- option to select from using the included comskip.ini, specify a path to an alternate, or using none

- recent v0.82.003

Here's builds for:

- Generic/x86_64: tools.comskip-8.2.90.zip

- RPi2/arm: tools.comskip-8.2.90.zip

I got an RPi3 recently and the attached (RPi2/arm) seems to run for me although the RPi runs very hot.

Realistically the comskip.ini needs to be adjusted for the channel as the generic one is hit and miss with the channels I use it with.

chewitt  CvH

Is it worth submitting to the repo if it'll be packaged with tvheadend in LE9.0? I probably don't have time to commit to maintaining it consistently to be honest but its seem functional at this point.

Thanks,

Shane

Quote from awiouy

I would be happy if a Rust developer would help me submitting code upstream, this for example.

Only took me a few months to figure it out . Lets see how this fares: Allow avahi support using dns-sd for Discovery by shanemeagher · Pull Request #246 · plietar/librespot · GitHub

Quote from awiouy

Please PR it upstream at librespot.

Done. Rust-Crypto fix for Intel "Westmere" CPU's by shanemeagher · Pull Request #208 · plietar/librespot · GitHub

Quote from shanemeagher

2. The librespot binary fails due to an issue in rust-crypto. A build with a fix for rust-crypto available for testing here (Haven't a NUC device myself to test).

awiouy This commit fixes the 2nd issue.

awiouy  T0mT0m I've had similar problems reported on my original repo. (I've asked them to report here but here's my summary as that issue has become muddled since it started on my initial builds but they now use the LibreELEC Repo version).

The two issues can be summarised as follows:

1. The librespot binary has issues resolving the AP address when starting. The odd time it starts, it fails with #2. I'm not sure what is causing this;

2. The librespot binary fails due to an issue in rust-crypto. A build with a fix for rust-crypto available for testing here (Haven't a NUC device myself to test).

The common thread is that it is on Intel NUCs. Awaiting more detailed debug logs.

I could be reading it wrong but the path looks hard coded to me:

self_update.rs#L338

    let rustc_manifest_path
        = PathBuf::from("/usr/local/lib/rustlib/manifest-rustc");
    let uninstaller_path
        = PathBuf::from("/usr/local/lib/rustlib/uninstall.sh")

awiouy I've tested an x86_64 build of the addon pushed to LibreELEC, librespot: initial addon by awiouy · Pull Request #1622 · LibreELEC/LibreELEC.tv · GitHub, and I can confirm its working as intended.

One issue encountered though when compiling is that adding rust to the depends results in a conflict with the existing rust that I have already installed on my system.

  BUILD    rust (target)
info: downloading installer
warning: it looks like you have an existing installation of Rust
warning: rustup cannot be installed alongside Rust. Please uninstall first
warning: run `/usr/local/lib/rustlib/uninstall.sh` as root to uninstall Rust
error: cannot install while Rust is installed

Rustup checks for other installs and exits with an error if it finds another (see rustup.rs/issues/953). Not sure if we can edit the downloaded install scripts on the fly as suggested in comment-299596429 until a fix is added upstream.

klisk the log lines we will need come after the lines shown above. They will not mention librespot in every line. Can you post a full debug log?

Thanks pushing this forward awiouy. I haven't had much time lately to help.

Quote from awiouy

libogg/libvorbis do not seem to be required (ldd librespot does not show them).

I've had mixed results with leaving libogg and libvorbis out (remove both twice, only to have to re-add them). With your current pull request on x86_64 (librespot: initial addon by awiouy · Pull Request #1622 · LibreELEC/LibreELEC.tv · GitHub), I get ERROR:librespot::player: Vorbis error: InvalidSetup in the output randomly. Tracks still play and even with the same track, it doesn't always occur.

Quote from awiouy

wizard could use librespot output rather than pyalsaaudio, but I did not manage to list devices/mixers. Any success with that?

Are you referring to --devices ?? This never worked for me either.

Quote from Apollos

I did an ssh into the system to run it manually and see what happens, and after reading file, the last output line is "segmentation fault (core dump)"

Would you be able to post the full output when you run manually over ssh? It could be an issue with how I compiled it. As everything on LibreELEC runs as the root user, I don't think it is the same issue as the linked post.

I'll have a look at adding a default ini file like the OpenELEC version referenced. I only built it to use personally in a situation where I have a few different ini files for different tv networks so the post recording script selects the ini file to use. From memory, the ini needs to be tailored to get the most out of comskip.

Hi awiouy,

Your suggestions are probably the right way to go and thanks for having a look. The addon definitely could do with a clean up, although my coding is limited to borrowing bits (mainly from your Spotify Connect Web addon so you'll recognise the code ) and hacking it together so glad to have the help. I'll keep an eye on github.

Quote from Apollos

For anyone reading this and wanting to get it to run, I had to first change my tvheadend interface level to "Expert" and uncheck "Replace whitespace in title with '-':" to get the addon to run.

This will depend on what TVHeadend names the recordings. If your recordings have whitespaces in their names, this will be required.

Quote from Apollos

Do I need to put the comskip.ini file in a specific location?

Comskip will look by default where the comskip binary is '/storage/.kodi/addons/tools.comskip/bin/' but this will be overwritten by updates to the addon. Suggest to use '/storage/.kodi/userdata/addon_data/tools.comskip/' (create folder if not present) but it can be anywhere which isn't overwritten by updates. Place ini files there and when calling comskip, use '--ini=<path to ini file>/comskip.ini', e.g.

comskip --ini=/storage/.kodi/userdata/addon_data/tools.comskip/comskip.ini

to specify which ini file to use.

Can you try this: tools.comskip-8.1.2.zip

I haven't tested it but should run.

Hi Apollos, the instructions in the README file for placing it in '/packages/addons/' is for compiling the addon. It needs to be compiled from source for each architecture (x86_64, ARM, etc). You can try yourself by following instructions here: Compile - LibreELEC or if I get some free time this week, I'll make one.

Hi,

Is it possible to compile a program written in Rust from within the LibreELEC Build System?

I'm working on an addon using librespot and I currently just copy pre-built binaries when building the addon.

Thanks,
Shane

gr00vy69, I've previously built an Comskip addon (GitHub - shanemeagher/tools.comskip: Comskip packaged as addon for LibreELEC). It just provides the comskip binary which can be called with a TVHeadend Post Recording Script. I've an x86_64 build here: kodi-repo/x86_64 at master · shanemeagher/kodi-repo · GitHub.

Very true &#128512;. Was hoping to make it (GitHub - shanemeagher/service.librespot: Spotify Connect Addon for LibreELEC) as straight forward as possible to avoid tinkering with people's setups. Will make this Plan B, and try to get librespot to play nice with avahi.

Is there a way to go about overriding the default avahi-daemon config? Seeing as its not possible to edit /etc/avahi/avahi-daemon.conf.

When you say build, do you mean build LibreELEC from source, with the configuration modified?