TBS5281 suspend support in Libreelec 8.0

schneci · March 27, 2017 at 3:23 PM

I'm using the TBS-5281 dvb-c USB module with Tvheadend 4.2 in Libreelec 8.0.0 environment. This Libreelec version uses the Linux 4.9.8 version.

I would like to sleep the system is used by Kodi Krypton suspend power-off option, but the system is freezed. If I have disconnected the USB module from system the suspend process has worked correctly.
In next step I have rebooted and reconnected the USB hardware to Libreelec and I have tested the cx231xx module dependency tree by lsmod command:

Code

lsmod | grep cx
cx231xx_dvb_ci         14873  0
tas2101                 8235  1 cx231xx_dvb_ci
dvb_core               82018  1 cx231xx_dvb_ci
cx25840               138349  1
cx231xx               147335  1 cx231xx_dvb_ci
videobuf_vmalloc        4231  1 cx231xx
videobuf_core          14600  2 cx231xx,videobuf_vmalloc
cx2341x                15535  1 cx231xx
i2c_mux                 4330  2 si2168,cx231xx
v4l2_common             3125  3 cx2341x,cx231xx,cx25840
tveeprom               13169  1 cx231xx
videodev              113087  4 cx2341x,v4l2_common,cx231xx,cx25840
rc_core                17350  4 `imon,rc_imon_pad,cx231xx

Display More

Before I removed from memory the dvb driver module I have stopped the tvheadend by using the following commands:

Code

systemctl stop service.tvheadend42


systemctl is-active service.tvheadend42
inactive

After this randomly sometimes rmmod cx231xx_dvb_ci command answers:
rmmod: ERROR: Module cx231xx_dvb_ci is in use
or
Killed

I think it doesn't normal message, may be it is a Linux kernel module problem.

BTW I will use the `89-tvheadend.power` script file in /storage/.config.sleep.d for stopping and restarting the dvb modules, but until doesn't solve above problem I couldn't use it. The `REMOVE_MODULE` variable can be set in Tvheadend42 addon configuration panel which will be included the removing module name sequence.

Code

. /etc/profile


oe_setup_addon service.tvheadend42


SERVICE="service.tvheadend42"


case "$1" in
  pre)
    if systemctl is-active "$SERVICE" &>/dev/null ; then
      systemctl stop "$SERVICE"
      for module in $REMOVE_MODULES ; do
        rmmod $module
      done
    fi
    ;;
  post)
    if systemctl is-enabled "$SERVICE" &>/dev/null ; then
      for module in $REMOVE_MODULES ; do
        modprobe $module
      done
      systemctl start "$SERVICE"
    fi
    ;;
esac

Display More

Can somebody help me?

PS: I'm sending some additional information:

Code

modinfo cx231xx
filename:       /lib/modules/4.9.8/updates/cx231xx.ko
version:        0.0.3
license:        GPL
description:    Conexant cx231xx based USB video device driver
author:         Srinivasa Deevi <[email protected]>
firmware:       v4l-cx23885-enc.fw
srcversion:     69AE4B51D811435B01A920C
...
depends:        videobuf-core,videodev,v4l2-common,tveeprom,cx2341x,videobuf-vmalloc,rc-core
vermagic:       4.9.8 SMP mod_unload
parm:           pcb_debug:enable pcb config debug messages [video] (int)
parm:           mpegbufs:number of mpeg buffers, range 2-32 (int)
parm:           mpeglines:number of lines in an MPEG buffer, range 2-32 (int)
parm:           mpeglinesize:number of bytes in each line of an MPEG buffer, range 512-1024 (int)
parm:           v4l_debug:enable V4L debug messages (int)
parm:           core_debug:enable debug messages [core] (int)
parm:           reg_debug:enable debug messages [URB reg] (int)
parm:           alt:alternate setting to use for video endpoint (int)
parm:           tuner:tuner type (int)
parm:           transfer_mode:transfer mode (1-ISO or 0-BULK) (int)
parm:           disable_ir:disable infrared remote support (int)
parm:           i2c_scan:scan i2c bus at insmod time (int)
parm:           i2c_debug:enable debug messages [i2c] (int)
parm:           isoc_debug:enable debug messages [isoc transfers] (int)
parm:           card:card type (array of int)
parm:           video_nr:video device numbers (array of int)
parm:           vbi_nr:vbi device numbers (array of int)
parm:           radio_nr:radio device numbers (array of int)
parm:           video_debug:enable debug messages [video] (int)

Display More

Code

modinfo cx231xx_dvb_ci
filename:       /lib/modules/4.9.8/updates/cx231xx-dvb-ci.ko
license:        GPL
author:         Srinivasa Deevi <[email protected]>
description:    driver for cx231xx based DVB cards
depends:        cx231xx,dvb-core,tas2101
vermagic:       4.9.8 SMP mod_unload
parm:           debug:enable debug messages [dvb] (int)
parm:           adapter_nr:DVB adapter numbers (array of short)

Code

modinfo si2168
filename:       /lib/modules/4.9.8/updates/si2168.ko
firmware:       dvb-demod-si2168-b40-01.fw
firmware:       dvb-demod-si2168-a30-01.fw
firmware:       dvb-demod-si2168-a20-01.fw
license:        GPL
description:    Silicon Labs Si2168 DVB-T/T2/C demodulator driver
author:         Antti Palosaari <[email protected]>
alias:          i2c:si2168
depends:
vermagic:       4.9.8 SMP mod_unload

Display More

Code

modinfo si2157
filename:       /lib/modules/4.9.8/updates/si2157.ko
firmware:       dvb-tuner-si2141-a10-01.fw
firmware:       dvb-tuner-si2158-a20-01.fw
license:        GPL
author:         Antti Palosaari <[email protected]>
description:    Silicon Labs Si2146/2147/2148/2157/2158 silicon tuner driver
alias:          i2c:si2141
alias:          i2c:si2146
alias:          i2c:si2157
depends:
vermagic:       4.9.8 SMP mod_unload

Display More

**CvH** · March 27, 2017 at 6:44 PM Official Post

the easiest way to test it

boot to normal LE
systemctl stop service.tvheadend42
rmmod cx231xx_dvb_ci cx231xx cx2341x

the rmmod ... has to work without an error - if you have an error you have to adjust the chain (you can't unload something that is used from another module), if you have a working unload chain you can also input it into the addon settings, then you won't need to do some script

schneci · March 27, 2017 at 7:07 PM

Quote from CvH

the easiest way to test it

boot to normal LE
systemctl stop service.tvheadend42
rmmod cx231xx_dvb_ci cx231xx cx2341x

the rmmod ... has to work without an error - if you have an error you have to adjust the chain (you can't unload something that is used from another module), if you have a working unload chain you can also input it into the addon settings, then you won't need to do some script

I have test above mode but the result is not too promising:

Code

~ # rmmod cx231xx_dvb_ci cx231xx cx2341x
Segmentation fault
~ # rmmod cx231xx_dvb_ci cx231xx cx2341x
rmmod: ERROR: Module cx231xx_dvb_ci is in use
rmmod: ERROR: Module cx231xx is in use by: cx231xx_dvb_ci
rmmod: ERROR: Module cx2341x is in use by: cx231xx

I think segfault message is a dvb driver code problem or other mistake.

**CvH** · March 27, 2017 at 7:47 PM Official Post

the segfault could be some strange "error"

could you post the output from lsmod | paste ?

schneci · March 27, 2017 at 8:31 PM

Quote from CvH

the segfault could be some strange "error"

could you post the output from lsmod | paste ?

You can see the result: UhAF

**CvH** · March 27, 2017 at 9:01 PM Official Post

could you test if rmmod cx231xx_dvb_ci works ?

schneci · March 27, 2017 at 9:21 PM

Quote from CvH

could you test if rmmod cx231xx_dvb_ci works ?

Firstofall I stopped the tvheadend and after this issued the rmmod cx231xx_dvb_ci

~ # systemctl stop service.tvheadend42~ # systemctl is-active service.tvheadend42inactive~ #~ # rmmod cx231xx_dvb_ciKilled

I think the Killed answer is not normal message. Probably the dvb driver is crashed.

**CvH** · March 27, 2017 at 10:52 PM Official Post

Quote from schneci

I think the Killed answer is not normal message. Probably the dvb driver is crashed.

yes this shouldn't be the correct response
I guess you have Generic LE8.
Here LibreELEC-Generic.x86_64-8.0.1-cc-2017-22-03.img.gz is a version with the latest TBS drivers, maybe it is fixed.

schneci · March 28, 2017 at 6:54 AM

Quote from CvH

yes this shouldn't be the correct response
I guess you have Generic LE8.
Here LibreELEC-Generic.x86_64-8.0.1-cc-2017-22-03.img.gz is a version with the latest TBS drivers, maybe it is fixed.

I have installed above image without tvheadend plugin install, but unfortunately the same situation:

rmmod try stops the cx231xx_dvb_ci module with Segfault or Killed message
kodi suspend freezes
kodi suspend works unplugged dvb usb hardware

lsmod output is before rmmod cx231xx_dvb_ci: GQSZ
and after rmmod: NLHT

The different is:
Module Size Used bysi2157 5741 2si2168 8881 2cx231xx_dvb_ci 15513 0

...

Module Size Used bysi2157 5741 1si2168 8881 1cx231xx_dvb_ci 15513 -1

**CvH** · March 28, 2017 at 10:01 AM Official Post

so lets guess cx231xx_dvb_ci is kind of broken, do you need the CI ?
If not you could blacklisting the module and maybe then the other stuff works.echo "blacklist cx231xx_dvb_ci" >> /storage/.config/modprobe.d/blacklist.conf
then try rmmod without the ci module

schneci · March 28, 2017 at 7:52 PM

Quote from CvH

so lets guess cx231xx_dvb_ci is kind of broken, do you need the CI ?
If not you could blacklisting the module and maybe then the other stuff works.echo "blacklist cx231xx_dvb_ci" >> /storage/.config/modprobe.d/blacklist.conf
then try rmmod without the ci module

Unfortunately it did not help, because the cx231xx_dvb_ci module is loaded and rmmod worked the same mistake as before. I don't know what is the reason of the blacklist didn't disable the loading of cx231xx_dvb_ci module.

You can see in end of dmesg what happened after rmmod cx231xx_dvb_ci:
FNJj

I think the following messages in dmesg are caused the rmmod Killed or Segfault output:

[ 50.184375] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010[ 50.184546] IP: [<ffffffffa09f7306>] dvb_fini+0xf6/0x150 [cx231xx_dvb_ci]

I use OSCAM system for encrypted channels receiving with PCSCD conax card reader driver. I don't know that ci-api should be for encoding operation. I think tvheadend uses CCAM interface protocol with OSCAM

schneci · March 30, 2017 at 9:55 AM

I think I have found the main problem. The TBS 5281 usb card includes dual adapter. The TBS proprietary driver use the adap_cnt counter variable:

Code

[CX231XX_BOARD_TBS_5281] = {
        .name = "TurboSight TBS 5281",
        .tuner_type = TUNER_ABSENT,
        .decoder = CX231XX_AVDECODER,
        .output_mode = OUT_MODE_VIP11,
        .demod_xfer_mode = 0,
        .ctl_pin_status_mask = 0xFFFFFFC4,
        .agc_analog_digital_select_gpio = 0x00,
        .tuner_sif_gpio = -1,
        .tuner_scl_gpio = -1,
        .tuner_sda_gpio = -1,
        .gpio_pin_status_mask = 0x4001000,
        .tuner_i2c_master = 2,
        .demod_i2c_master = 1,
        .has_dvb = 1,
        .adap_cnt = 2,
        .demod_addr = 0x64,
        .norm = V4L2_STD_PAL_M,
        
        .input = {{
            .type = CX231XX_VMUX_TELEVISION,
            .vmux = CX231XX_VIN_3_1,
            .amux = CX231XX_AMUX_VIDEO,
            .gpio = NULL,
        }, {
            .type = CX231XX_VMUX_COMPOSITE1,
            .vmux = CX231XX_VIN_2_1,
            .amux = CX231XX_AMUX_LINE_IN,
            .gpio = NULL,
        }, {
            .type = CX231XX_VMUX_SVIDEO,
            .vmux = CX231XX_VIN_1_1 |
                (CX231XX_VIN_1_2 << 8) |
                CX25840_SVIDEO_ON,
            .amux = CX231XX_AMUX_LINE_IN,
            .gpio = NULL,
        } },
    },

Display More

The kernel BUG message in dmesg shows the problem is caused by dvb_fini process with kernel NULL point exception during rmmod. I have seen the TBS proprietary driver source and this calculates the adapter number in adapter release and unregister calling, but the opensource cx231xx driver not:

Code

static int dvb_fini(struct cx231xx *dev)
{
    int i;


    if (!dev->board.has_dvb) {
        /* This device does not support the extension */
        return 0;
    }


    for (i = 0; i < dev->board.adap_cnt; i++) {
    if (dev->dvb[i]) {
        tbscxci_release(dev->dvb[i]);
        unregister_dvb(dev->dvb[i]);
        dev->dvb[i] = NULL;
    }
    }


    return 0;
}

Display More

What is your opinion? Can anybody help to solve this problem?

**CvH** · March 30, 2017 at 10:05 AM Official Post

btw Iam subscribed at GitHub - tbsdtv/linux_media: TBS linux open source drivers

I am no help here, but as you already saw it is a driver problem, hopefully they can fix it (I can build an updated LE)

**CvH** · March 30, 2017 at 11:45 PM Official Post

LibreELEC-Generic.x86_64-8.0.1-cc-suspend-fix.img.gz
version with the proposed fix

schneci · March 31, 2017 at 8:48 AM

Hi Cvh,

Thank you your advice, I have earlier put this issue on that Github site.

The dvd-drivers branch of GitHub - CvH/LibreELEC.tv: 'Just enough OS' for Kodi site is working by TBS528 and I correctly use rmmod of cx231xx driver and I can use Librelec 7 (kodi 16.1) suspend power-off option. On this site I found the LE8-dvb-drivers branch but I couldn't use it because the dvb-drivers.txt file is handled inaccurate:

LibreELEC.tv/init at LE8-dvb-drivers · CvH/LibreELEC.tv · GitHub

Code

# DVB driver selection
  select_drivers() {
    progress "Loading DVB modules"
    rm -rf /sysroot/storage/.modules &>/dev/null


    [ -f "/sysroot/storage/.cache/dvb-drivers.txt" ] && . /sysroot/storage/.cache/dvb-drivers.txt
    CORE_VER=$(uname -r)


    case "$DVB_DRIVERS" in
      "MEDIA")             # Media_Build drivers
          DRIVER="mb"
       ;;
      "CC")                # CrazyCat drivers
          DRIVER="cc"
       ;;
      "TBS")               # TBS proprietary drivers
          DRIVER="tbs"
       ;;
      "TBSC")              # TBS DVBCproprietary drivers
          DRIVER="tbsc"
       ;;

Display More

Above code doesn't read dvb-drivers.txt.

What was your goal of this branch? Has anybody used this version? I would like using the "tbsc" driver option for TBS-5281 adapter.

**CvH** · March 31, 2017 at 8:54 AM Official Post

this branch isn't finished yet so it won't work

I created a version with the fix proposed at github LibreELEC-Generic.x86_64-8.0.1-cc-suspend-fix.img.gz

there you can test

schneci · March 31, 2017 at 9:37 PM

Thank you the new image.

I have tested it and now is working the rmmod of cx231xx_dvb_ci module and properly go to suspend the kodi.

When this repaired version wil be appeared on github? What is the schedule the libreelec8.0 release?

Thank you again for your effort solving of this problem!

**CvH** · April 1, 2017 at 9:00 AM Official Post

Quote from schneci

When this repaired version wil be appeared on github?

I pr the changes and create an test image that you pls test if this also work at the versions LE 8.0.x uses.