Hi heitbaum
because of your comment at https://github.com/LibreELEC/LibreELEC.tv/pull/10658 I'm a little confused. What is the intended usage of PKG_VERSION and PKG_REV?
Currently the build process combine both informations like PKG_VERSION + PKG_REV:
- PKG_VERSION="1.1.13" + PKG_REV="0" results to addon version="1.1.13.0".
If both symbols are set, why do you want that the PKG_REV should be increased as well? I'm trying to understand, because in the past I started every time with "0" as long the add-on with the new PKG_VERSION was never build before and uploaded afterwards to the repo. if just the build process needs some changes (without changes of the source package), the PKG_REV can increased additional to force a new version in the add-on repo.
I have seen that you have increased both symbols at the same time: https://github.com/LibreELEC/LibreELEC.tv/pull/10653/files
, but currently couldn't recognise the reason for. For example the filebrowser would results in a version jump: 2.44.2.4 -> 2.45.0.5
Usually increasing PKG_VERSION would be enough to trigger a new add-on version, because 2.45.0 is already a successor of 2.44.2. https://kodi.wiki/view/Addon.xml#Core_elements
Do I missed some other ruleset?
EDIT:
Okay, I have now seen in the add-on repo that the creation process for most (but not all) add-ons behaves differently from the current one for argononecontrol and hides the source version behind a new add-on version that corresponds to the ADDON_VERSION symbol. So I think your assumption was that this is also the case with argononecontrol. Now I understand your objections/intention, but ends with some new questions:
- Should I from now increase every time the last digit (PKG_REV) within the add-on repo of the corresponding LE version, also if it's technically not necessary?
- May it be okay for the future to still have a speaking add-on version, other than the LE 12.x.x.x/13.x.x.x one? Or it's planned/necessary to make it sometimes equal? Reason: The current behaviour is welcome, because the current scheme generates no conflicts with the manually installed versions for testing from GitHub.
Regards,
Harry