Posts by koenkooi

    The latest build from kszaq already has it, but if you have an existing /storage/.config/smb.conf you'll need to update it manually.

    LE 8.1/8.2 and master have a patch to backport the autonegotiation from samba 4.7: samba: backport default to SMB3_11 from Samba 4.7 · LibreELEC/[email protected] · GitHub


    So if you have no 'min' or 'max' protocol in your config it will try to negotiate smb3.11 first and work down the list on failure.

    Hmmm this is what I feared...
    15m cables are almost never capable of those bandwidths.

    Have you tried to use a short (3m max), good HDMI 2 cable directly between box and JVC?

    FWIW, there are no such things as "HDMI 2.0" cables. The only thing the HDMI alliance does is specify a 'premium' label (with QR code so you can check it yourself), which in practice means it works for 2.0, because it was actually tested.

    So far all three premium cables I bought work great with 4k60/444, the non-premium "2.0 + ethernet cables" are hit and miss. They are sadly 3 times the prices of regular cables, though :(

    That's probably it. My TV's internal player does not exhibit banding though. Is dithering supposed to be turned on?


    I'll just post the clip again.
    hdr_banding.mkv

    To all the people with an HDR capable set:

    Play this file and please report back whether or not you can see banding artifacts within the white gradient.

    I don't see banding, but I do see some form of slim vertical stripes which I think are dithering artefacts. I had to walk up to the TV to see those, though :)

    can a s905x handle x264 4k/60fps video? i've tried all the big buck bunny 2D files. it can play them properly except for the 2 videos below. so i think it must be a hw limitation


    bbb_sunflower_2160p_60fps_normal.mp4

    bbb_sunflower_native_60fps_normal.mp4

    It can, it was fixed in a 7.x kszaq build a while ago, but recent kernel/kodi updates might have changed that. But yes, plain s905 is better at h264 than s905x.

    I have a new test build I'm not updating OP with because it's very experimental and the last build is in a good state. You can use the linked device trees from OP.


    Changes:

    • A very experimental buffer change in an attempt to improve the frame skip situation.
    • A hdmitx change that may improve compatibility with some AVRs (to be tested by those with 4k output on their TVs but not AVRs).


    A build with KERNEL_VERSION="4e39713" still gives me frameskips on h264/4k. But I only have a single movie using that and I can't see any visual difference between the 4k version and the bluray I can't say I care a lot about this bug :) 1080p h264 works great, as does 4k h265.

    I'm very interested to know if this fixes the issue for you. Unfortunately the hpll reg testing for the output issue hasn't been going quite as smooth as I'd hoped.

    I did a build with KERNEL_VERSION="b05cd25" and the following cherry-picks from your tree:

    Code
    1. + 2b5bbfb661fb6ee7603ed584c76ba35a78dc8510 S905: update audio config and patches
    2. + e0d87740a4c7ef327ca3d9bb915546be0f571a24 S905: use custom test kernel
    3. + 1ac55183798d10b148c207527b856acd65d519bf projects/S905: set same mode during switch
    4. + 129ed2cd207b226e22bf398066fc96e72fc4ab0d kodi/patches/amlogic: @afl1 lateframes patch
    5. + 25cc0edccc5591646158874fa9f9c0bf1ec9e72b Revert "projects/S9*: fix BBC H.264 DVB-T"
    6. + c852260023320f9d2bb42c3a853b5455d63844c5 S905: bump kernel

    With GUI set to 1080p50 and having done echo '444,10bit' > /sys/class/amhdmitx/amhdmitx0/attr all the previously mentioned issues are gone. I get artefact free and skipless playback on 'passengers', 'lucy', 'PE II' and web-dl content.


    However, I did notice an issue with 4k h264 SDR playback ('deadpool'), a lot of frameskips there. I went back to your previous hybrid nougat/mm kernel and frameskips are worse there, about double.


    All in all this seems to be the best 4k/hdr configuration so far, good work!

    You're right, it is stuck at 5 (SDR8 output) on anything other than GXM. I got HDR10 with a test file but didn't see it had HDR10 metadata. Thank you, my mistake.


    koenkooi It's built with the latter. I forgot to push the LE kernel bump.

    Good, then I've built and tested the same kernel :) 'echo 444,10bit' still gives me various issues, including a new 'resolution error' on the AVR. But like jd17 I'm going to wait for new HMDI cables to arrive before drawing any conclusions. So no real testing till tuesday evening, sorry.


    I did notice that 'echo 422,10bit' falls back to 422,8bit on Passengers and the Smurfs according to my AVR.

    Uploaded a new build in OP. Changes:

    • Removed "output_rgb" interface completely since it's redundant (see OP).
    • h264 dolby vision support (nougat backport)
    • Fixed too high of contrast (nougat backport)
    • New white balance module (nougat backport)
    • A few HDR fixes (nougat backports)
    • Added section in OP on dolby vision.

    Is this built with KERNEL_VERSION="6b34aaf" or KERNEL_VERSION="65c65db"? The changelog implies the latter, but your LE repo says the former.

    Some more digging into 'regular'/SDR content, with KERNEL_VERSION="361e832":

    1. Blu-ray backups and re-encodes seem to work fine; 30s sample (32MiB)
    2. 'web-dl' type of media has tons of frameskips; 30s sample (17MiB)

    Here's the log file for a frameskipping video, after doing 'echo 422,10bit > /sys/class/amhdmitx/amhdmitx0/attr ; systemctl restart kodi'. For future logs, LE has 'pastebinit' builtin:

    Code
    1. m8s:~ # cat ~/.kodi/temp/kodi.log | pastebinit
    2. http://sprunge.us/LgfX

    I still haven't replaced the HDMI cable, so saying that PEII still makes the AVR say 'no signal' is a bit useless.

    I have my GUI set to 1080p50 after discovering that 2160p is worse due to scaling. I'll try to do the tests you suggested this weekend.

    Without echo '444,10bit' > /sys/class/amhdmitx/amhdmitx0/attr


    PE II: Vertical banding in sun during intro, AVR says ‘YCbCr420, 24 bit’

    Passengers: OK, AVR says ‘YCbCr4444, 24bit’

    1080p24 SDR: Tons of frameskips


    After echo '444,10bit' > /sys/class/amhdmitx/amhdmitx0/attr


    PE II: TV says “no input”, AVR says it does have input

    Passengers: white dots in picture, audio glitches, AVR says ‘YCbCr444, 30bit’. Could be cable related.

    1080p24 SDR: Tons of frameskips, AVR says ‘YCbCr4444, 30bit’