chewitt , I have not noticed any negative changes after I modified the max_width and max_height, mostly youtube videos. But I agree, changing to 1920x1920 is a safer tweak.
Posts by hephooey
-
-
chewitt , you are 100% right, I guess you are talking about the vh264_4k2k.c in the vendor kernel, impressive amount of engineering in it. On the other hand does the cap in the current kernel actually helps in anyway? It seems the variables are only used to crop the output. But based on the content of vh264_4k2k.c one needs a different firmware to even decode the stream, so I assume 4K video will fail the same way with or without this constraint. On the other hand when the input is something the standard h264 code can handle, like 1080x1920, the cropping just output a little more than the upper half of the video, which hurts user experience.
-
Somewhat related to this, I do not think h264 4K video works with upstream kernel either, the max resolution is limited to 1920x1080. Modifying the limit to 3840x2160 allows me to play portrait 1080x1920 video without been clamped to 1080x1080, did not test real 4K videos.